Add tests for deploying Karmada services using the configuration file with the karmadactl init --config command.(closed) #5744
Conversation
karmada-bot
requested review from
chaosi-zju,
chaunceyjiang,
liangyuanpeng and
zhzhuang-zju
|
Hi, this is a bot comment, just put the label of /ok-to-test |
karmada-bot
added
ok-to-test
size/XXL
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5744 +/- ##
==========================================
+ Coverage 41.64% 41.68% +0.03%
==========================================
Files 653 653
Lines 55484 55533 +49
==========================================
+ Hits 23109 23147 +38
- Misses 30876 30885 +9
- Partials 1499 1501 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tiansuo114
force-pushed
the
config_test
branch
from
e80a8be
to
5f91992
Compare
karmada-bot
added
size/L
|
Since the PR for adding features has been merged, the commit history in this PR is now normal, so we can proceed with the review and merging correctly. |
|
Ping @liangyuanpeng to review. |
hack/cli-testing-init-with-config.sh
Outdated
| -e "s|\${VERSION}|${VERSION}|g" \ | ||
| -e "s|\${HOME}|${HOME}|g") | ||
|
|
||
| echo "$filled_config" > $CONFIG_FILE_PATH |
There was a problem hiding this comment.
| echo "$filled_config" > $CONFIG_FILE_PATH | |
| echo "${filled_config}" > ${CONFIG_FILE_PATH} |
hack/cli-testing-init-with-config.sh
Outdated
|
|
||
| echo "$filled_config" > $CONFIG_FILE_PATH | ||
|
|
||
| echo "Karmada init config file generated at $CONFIG_FILE_PATH" |
There was a problem hiding this comment.
| echo "Karmada init config file generated at $CONFIG_FILE_PATH" | |
| echo "Karmada init config file generated at ${CONFIG_FILE_PATH}" |
hack/cli-testing-init-with-config.sh
Outdated
| apiVersion: config.karmada.io/v1alpha1 | ||
| kind: KarmadaInitConfig | ||
| metadata: | ||
| name: karmada-init |
There was a problem hiding this comment.
seems like this is unnecessarily.
There was a problem hiding this comment.
My understanding is that the information in the metadata is redundant. In the current karmadactl system, the data in the metadata is indeed unnecessary. I have already removed the related data items and addressed the issues mentioned in other comments. If my understanding is incorrect or if additional issues are identified, I hope you can let me know. I look forward to your further guidance.
Signed-off-by: tiansuo114 <[email protected]> 11 Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]>
tiansuo114
force-pushed
the
config_test
branch
from
5f91992
to
82d1825
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Based on the OSPP project's requirements, the content of this PR has been moved to this pr, and this PR will be closed. |
tiansuo114
changed the title
What type of PR is this?
What this PR does / why we need it:
This PR is an additional test, based on the suggestion provided in url.
Which issue(s) this PR fixes:
Part of #5387
It adds test cases for deploying Karmada services using the
karmadactl init --configcommand with a configuration file, similar to the existing tests forkarmadactl init.Special notes for your reviewer:
@liangyuanpeng
@RainbowMango
This PR currently contains two commits because the test files depend on the new feature for deploying with a configuration file, introduced in #5357. Once that PR is merged, this PR will be rebased, retaining only the commit for adding test cases. However, to save time, it is being submitted for review in advance.Does this PR introduce a user-facing change?: