Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifact deployment to workflow_dispatch to keep client and agents in sync #341

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

emerkle826
Copy link
Contributor

Fixes #339

This will publish all of the project Maven artifacts at the same time as the Client jar so that downstream projects can access the same version of the agent(s) and server files as the client jarfile.

@Miles-Garnsey
Copy link
Member

Suggestion: comment out artifactory related jobs and make a comment that they don't work at the moment.

@Miles-Garnsey
Copy link
Member

@emerkle826 looks like we have failing tests here, happy to review once they're passing!

@emerkle826
Copy link
Contributor Author

@Miles-Garnsey A re-run of the tests and they are all passing now. At some point I will dig into the flaky one as it's not always the same test, but usually the same symptom....

@Miles-Garnsey
Copy link
Member

We've validated that manually running the Publish OpenAPI client does push both client and agent jars to Cloudsmith.

The workflow that is run is the one on the branch, not the one on main, so we have been able to validate this prior to merge.

Erik has confirmed that no rebase is applied to the branch prior to the new publication CI jobs running, so the commit sha from HEAD is the correct one to apply to the artifacts.

The only thing remaining prior to approval is to comment out the DataStax publication target, since that isn't working at present.

@Miles-Garnsey
Copy link
Member

DataStax publication option is removed. This is ready for merge pending green CI.

Copy link
Member

@Miles-Garnsey Miles-Garnsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, approving and merging.

@Miles-Garnsey Miles-Garnsey merged commit 680ffc4 into master Aug 15, 2023
46 of 47 checks passed
@Miles-Garnsey Miles-Garnsey deleted the artifact-publish branch August 15, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI client publish does not also publish other artifacts
2 participants