Add notification details to the repair process #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @burmanm, looks like we have failing tests so there are a few preliminary things to do here:
Thanks! |
|
There are no v2 endpoints in the current mgmt-api master or any structures to them. And this is basically just v0, but added String return result (I was actually considering just changing v0, but since the meta has been v1 for these type of changes, this goes better with v1). |
emerkle826
reviewed
Aug 15, 2023
| @RpcParam(name = "keyspaceName") String keyspace, | ||
| @RpcParam(name = "tables") List<String> tables, | ||
| @RpcParam(name = "full") Boolean full) | ||
| @RpcParam(name = "full") Boolean full, | ||
| @RpcParam(name = "async") boolean notifications) |
There was a problem hiding this comment.
Question:
Why name the parameter "async" but call the variable "notifications"? It would be less confusing if they were named the same or similarly.
There was a problem hiding this comment.
Changed. Although I'm not sure if the RpcParam's name is used anywhere?
|
I have no idea why the tests are not running without doing close/reopen. |
So this is the setup for the workflow: It should run on any commit push, or when a PR is opened or re-opened. I changed that recently as it would run CI twice on a commit push, which is a waste, once for the commit push, once for the update tho the PR. Maybe I'm not understanding how to set this up correctly.... |
Miles-Garnsey
requested changes
Aug 17, 2023
management-api-agent-common/src/main/java/com/datastax/mgmtapi/util/Job.java
Show resolved
Hide resolved
management-api-server/src/main/java/com/datastax/mgmtapi/resources/v1/NodeOpsResources.java
Show resolved
Hide resolved
management-api-server/src/main/java/com/datastax/mgmtapi/resources/v1/NodeOpsResources.java
Show resolved
Hide resolved
Miles-Garnsey
approved these changes
Aug 22, 2023
…l - should fix the test also which can not be run otherwise on single node cluster
This is just trying to get GHA flakes out of the way.. slow down the HTTP client call return
emerkle826
added a commit
that referenced
this pull request
Sep 15, 2023
* Add repair job version which follows notifications * Add new getStatusChanges and message * Fix formatting * Add tests for the async endpoint in v1 also * Change setStatusChange * Fix test indentation * Rename RpcParam * Fix rebase * Add back the payload in the IT test to the request * Update openapi.json, make special case for return id 0 to the Rpc call - should fix the test also which can not be run otherwise on single node cluster * Disable the test, throw exception if Cassandra refuses to repair * Fix repair test to run repair for a keyspace with RF 2 (#351) * Update openapi.json after rebase --------- Co-authored-by: Erik Merkle <[email protected]>
emerkle826
added a commit
that referenced
this pull request
Sep 15, 2023
* Add repair job version which follows notifications * Add new getStatusChanges and message * Fix formatting * Add tests for the async endpoint in v1 also * Change setStatusChange * Fix test indentation * Rename RpcParam * Fix rebase * Add back the payload in the IT test to the request * Update openapi.json, make special case for return id 0 to the Rpc call - should fix the test also which can not be run otherwise on single node cluster * Disable the test, throw exception if Cassandra refuses to repair * Fix repair test to run repair for a keyspace with RF 2 (#351) * Update openapi.json after rebase --------- Co-authored-by: Erik Merkle <[email protected]>
emerkle826
added a commit
that referenced
this pull request
Oct 12, 2023
* Add repair job version which follows notifications * Add new getStatusChanges and message * Fix formatting * Add tests for the async endpoint in v1 also * Change setStatusChange * Fix test indentation * Rename RpcParam * Fix rebase * Add back the payload in the IT test to the request * Update openapi.json, make special case for return id 0 to the Rpc call - should fix the test also which can not be run otherwise on single node cluster * Disable the test, throw exception if Cassandra refuses to repair * Fix repair test to run repair for a keyspace with RF 2 (#351) * Update openapi.json after rebase --------- Co-authored-by: Erik Merkle <[email protected]>
emerkle826
added a commit
that referenced
this pull request
Oct 12, 2023
* Add repair job version which follows notifications * Add new getStatusChanges and message * Fix formatting * Add tests for the async endpoint in v1 also * Change setStatusChange * Fix test indentation * Rename RpcParam * Fix rebase * Add back the payload in the IT test to the request * Update openapi.json, make special case for return id 0 to the Rpc call - should fix the test also which can not be run otherwise on single node cluster * Disable the test, throw exception if Cassandra refuses to repair * Fix repair test to run repair for a keyspace with RF 2 (#351) * Update openapi.json after rebase --------- Co-authored-by: Erik Merkle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a /api/v1 version of the /api/v0/ops/node/repair. Adds a new parameter to the Rpc method to indicate if the notifications should be received and stored in the job details.
The /api/v0/ops/node/repair was already async in execution, so /v1 simply adds the ability to follow notifications (and returns the job number to track it). Otherwise they're similar.
Fixes #342