Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup makefile #579

Merged

Conversation

adrianchiris
Copy link
Contributor

@adrianchiris adrianchiris commented Jul 24, 2024

  • cleanup makefile
  • update workflows
  • remove deprecated linters from .golangci.yml
  • allow to provide additional GO build options, ldflags and flags

@adrianchiris
Copy link
Contributor Author

@SchSeba @zeeke PTAL mellanox ci failure is un-related

@coveralls
Copy link
Collaborator

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 10079103746

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.187%

Totals Coverage Status
Change from base Build 9743694937: 0.0%
Covered Lines: 2115
Relevant Lines: 2813

💛 - Coveralls

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@adrianchiris
Copy link
Contributor Author

/test-all

- cleanup makefile
- update workflows
- remove deprecated linters from .golangci.yml

Signed-off-by: adrianc <[email protected]>
Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ;)

@adrianchiris adrianchiris merged commit a967ce4 into k8snetworkplumbingwg:master Jul 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants