Enable FIPS compliance by setting cgo to 1

[vrindle]

No description provided.

[bn222]

/approve

[bn222]

LGTM

[coveralls]

Pull Request Test Coverage Report for Build 10003815369

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 75.187%

---

Totals
Change from base Build 9743694937:	0.0%
Covered Lines:	2115
Relevant Lines:	2813

---

💛 - Coveralls

[SchSeba]

CI looks good and I don't have any objections on this one

cc @adrianchiris WDYT?

[adrianchiris]

do we really need this on by default ?

[bn222]

do we really need this on by default ?

what's the downside?

[adrianchiris]

what's the downside?
i think it mandates having a c compiler.

in my system its enabled by default (running go env)

so my preference is:

1. use default
2. allow override when needed by the user.

[bn222]

iow, you don't want to enforce having a c compiler?

[adrianchiris]

/test-all

[adrianchiris]

PR #579 will allow you to invoke : GO_BUILD_OPTS=CGO_ENABLED=1 make build which will override CGO_ENABLED
by default make build will use default value of CGO_ENABLED from go env which is 1 when gcc found and 0 when not found.

[adrianchiris]

PR #579 will allow you to invoke : GO_BUILD_OPTS=CGO_ENABLED=1 make build which will override CGO_ENABLED
by default make build will use default value of CGO_ENABLED from go env which is 1 when gcc found and 0 when not found.

per the comment above, closing this one as it should be possible to enable FIPs compliance with #579
please re-open and update PR if this is not the case.