Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #113 #117

Merged
merged 32 commits into from
Jul 9, 2024
Merged

resolves #113 #117

merged 32 commits into from
Jul 9, 2024

Conversation

jyaacoub
Copy link
Owner

@jyaacoub jyaacoub commented Jul 9, 2024

No description provided.

Due to logic error in code previous results was just functioning as jus gvpl (no aflow). See 8c89a24.
To evaluate sequence length vs mse
Underwhelming peformance, ESM didnt help at all with GVPL_aflow model
Accounting for error in aflow not being used.
Example usage:
```python
#%% now based on this test set we can create the splits that will be used for all models
# 5-fold cross validation + test set
import pandas as pd
from src import cfg
from src.train_test.splitting import balanced_kfold_split
from src.utils.loader import Loader

test_df = pd.read_csv('/home/jean/projects/data/splits/davis_test_genes_oncoG.csv')
test_prots = set(test_df.prot_id)

db = Loader.load_dataset(f'{cfg.DATA_ROOT}/DavisKibaDataset/davis/nomsa_binary_original_binary/full/')

#%%
train, val, test = balanced_kfold_split(db,
                k_folds=5, test_split=0.1, val_split=0.1,
                test_prots=test_prots, random_seed=0, verbose=True
                )

#%%
db.save_subset_folds(train, 'train')
db.save_subset_folds(val, 'val')
db.save_subset(test, 'test')
```
@jyaacoub jyaacoub linked an issue Jul 9, 2024 that may be closed by this pull request
@jyaacoub jyaacoub merged commit 4537407 into main Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify cross validation splits to use consistent sets
1 participant