Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conc: ddb-lock use backoff settings provided; #1009

Open
wants to merge 1 commit into
base: main
from
Open

conc: ddb-lock use backoff settings provided; #1009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pkg/conc/ddb/ddb_lock_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,23 @@ func NewDdbLockProvider(ctx context.Context, config cfg.Config, logger log.Logge
return nil, fmt.Errorf("can not create ddb repository: %w", err)
}

backoffConfig := backoff.NewExponentialBackOff()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used afterwards. But it should be used in line 78 instead of the backoff.NewExponentialBackOff()? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true it should use the backoffConfig instead

if settings.Backoff.InitialInterval > 0 {
backoffConfig.InitialInterval = settings.Backoff.InitialInterval
}

if settings.Backoff.MaxInterval > 0 {
backoffConfig.MaxInterval = settings.Backoff.MaxInterval
}

if settings.Backoff.MaxElapsedTime > 0 {
backoffConfig.MaxElapsedTime = settings.Backoff.MaxElapsedTime
}

return NewDdbLockProviderWithInterfaces(
logger,
repo,
backoff.NewExponentialBackOff(),
backoffConfig,
clock.NewRealClock(),
uuid.New(),
settings,
Expand Down