conc: ddb-lock use backoff settings provided; #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4k4
reviewed
Mar 13, 2023
| @@ -59,6 +59,19 @@ func NewDdbLockProvider(ctx context.Context, config cfg.Config, logger log.Logge | |||
| return nil, fmt.Errorf("can not create ddb repository: %w", err) | |||
| } | |||
|
|
|||
| backoffConfig := backoff.NewExponentialBackOff() | |||
There was a problem hiding this comment.
This is not used afterwards. But it should be used in line 78 instead of the backoff.NewExponentialBackOff()? 🤔
There was a problem hiding this comment.
true it should use the backoffConfig instead
j4k4
reviewed
Mar 13, 2023
netsi
force-pushed
the
conc-ddb-lock-use-backoff-setings-provided
branch
from
34fa3c2 to
0c32306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.