Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-toast): DSW-000 add missing package dependencies #1659

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix(pie-toast): DSW-000 add missing package dependencies #1659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-spoons-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@justeattakeaway/pie-toast": patch
---

[Added] - Missing package dependencies
3 changes: 3 additions & 0 deletions packages/components/pie-toast/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@
"cem-plugin-module-file-extensions": "0.0.5"
},
"dependencies": {
"@justeattakeaway/pie-button": "0.48.0",
"@justeattakeaway/pie-icon-button": "0.28.9",
"@justeattakeaway/pie-icons-webc": "0.24.2",
"@justeattakeaway/pie-webc-core": "0.24.0"
},
"volta": {
Expand Down
6 changes: 2 additions & 4 deletions packages/components/pie-toast/src/defs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { type ComponentDefaultPropsGeneric } from '@justeattakeaway/pie-webc-core';
import { type ComponentDefaultProps } from '@justeattakeaway/pie-webc-core';

// TODO - please remove the eslint disable comment below when you add props to this interface
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export type ActionProps = {
/**
* The text to display inside the button.
Expand Down Expand Up @@ -61,7 +59,7 @@ export const ON_TOAST_OPEN_EVENT = `${componentSelector}-open`;
*/
export const ON_TOAST_LEADING_ACTION_CLICK_EVENT = `${componentSelector}-leading-action-click`;

export type DefaultProps = ComponentDefaultPropsGeneric<ToastProps, 'isOpen' | 'isDismissible' | 'isMultiline'>;
export type DefaultProps = ComponentDefaultProps<ToastProps, keyof Omit<ToastProps, 'leadingAction' | 'message'>>;

export const defaultProps: DefaultProps = {
isOpen: true,
Expand Down
3 changes: 3 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5820,7 +5820,10 @@ __metadata:
resolution: "@justeattakeaway/pie-toast@workspace:packages/components/pie-toast"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-button": 0.48.0
"@justeattakeaway/pie-components-config": 0.16.0
"@justeattakeaway/pie-icon-button": 0.28.9
"@justeattakeaway/pie-icons-webc": 0.24.2
"@justeattakeaway/pie-webc-core": 0.24.0
cem-plugin-module-file-extensions: 0.0.5
languageName: unknown
Expand Down
Loading