Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pie-monorepo): DSW-000 update turbo filter syntax #1643

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/lovely-ducks-sneeze.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"pie-monorepo": minor
---

[Changed] - Update turbo filter syntax for GitHub Actions
[Changed] - Use the old UI for turbo console output
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,19 @@ jobs:
- name: Verify if pie-docs has changes
id: docs-check
run: |
DOCS_CHANGE=$(npx -y turbo run build --filter='{./apps/pie-docs}...[origin/main]' --dry=json | jq '.packages | length > 0')
DOCS_CHANGE=$(npx -y turbo run build --filter='./apps/pie-docs...[origin/main]' --dry=json | jq '.packages | length > 0')
echo "Change Detected: $DOCS_CHANGE"
echo "docs-change=$DOCS_CHANGE" >> $GITHUB_OUTPUT
- name: Verify if web components have changes
id: component-check
run: |
COMPONENT_CHANGE=$(npx -y turbo run build --filter='{./packages/components/*}...[origin/main]' --dry=json | jq '.packages | length > 0')
COMPONENT_CHANGE=$(npx -y turbo run build --filter='./packages/components/*...[origin/main]' --dry=json | jq '.packages | length > 0')
echo "Change Detected: $COMPONENT_CHANGE"
echo "web-components-change=$COMPONENT_CHANGE" >> $GITHUB_OUTPUT
- name: Verify if storybook has changes
id: storybook-check
run: |
STORYBOOK_CHANGE=$(npx -y turbo run build --filter='{./apps/pie-storybook}...[origin/main]' --dry=json | jq '.packages | length > 0')
STORYBOOK_CHANGE=$(npx -y turbo run build --filter='./apps/pie-storybook...[origin/main]' --dry=json | jq '.packages | length > 0')
echo "Change Detected: $STORYBOOK_CHANGE"
echo "storybook-change=$STORYBOOK_CHANGE" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -210,13 +210,13 @@ jobs:
uses: ./.github/actions/run-script
if: github.event_name != 'pull_request' && github.ref == 'refs/heads/main'
with:
script-name: "test:visual:ci --filter='{./packages/components/*}...[HEAD^1]'"
script-name: "test:visual:ci --filter='./packages/components/*...[HEAD^1]'"
concurrency: 1
- name: Run Changed Package Visual Tests
uses: ./.github/actions/run-script
if: (github.event_name == 'pull_request' && github.event.pull_request.draft == false) && github.ref != 'refs/heads/main'
with:
script-name: "test:visual:ci --filter='{./packages/components/*}...[origin/main]'"
script-name: "test:visual:ci --filter='./packages/components/*...[origin/main]'"
concurrency: 1
- uses: actions/upload-artifact@v3
if: always()
Expand Down
2 changes: 2 additions & 0 deletions apps/pie-docs/src/404.njk
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ notFoundNarrowImgSrc: '/assets/img/404_narrow.png'
---

{% include "not-found.njk" %}

Some docs site change
2 changes: 2 additions & 0 deletions packages/components/pie-modal/src/modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
--modal-size-m: 600px;
--modal-size-l: 1080px;

// Some component change

// The base modal defaults
--modal-border-radius: var(--dt-radius-rounded-d);
--modal-font: var(--dt-font-interactive-l-family);
Expand Down
2 changes: 1 addition & 1 deletion turbo.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://turborepo.org/schema.json",
"ui": "tui",
"ui": "stream",
"tasks": {
"build": {
"cache": true,
Expand Down
Loading