Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-monorepo): DSW-1969 updated Playwright and Percy dependencies OLD #1600

Closed
wants to merge 37 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5fc2a27
refactor(pie-monorepo): DSW-1969 updated tests and playwright packages
JoshuaNg2332 Jul 4, 2024
d7edba0
chore(pie-monorepo): DSW-1969 changesets file
JoshuaNg2332 Jul 5, 2024
f743363
chore(pie-monorepo): DSW-1969 yarn update
JoshuaNg2332 Jul 12, 2024
e4d07e4
chore(deps): dsw-000 update dependency @rollup/plugin-commonjs to v25…
renovate[bot] Jul 12, 2024
80c5468
fix(pie-assistive-text): DSW-1969 updated visual test to fix promise …
JoshuaNg2332 Jul 15, 2024
7316310
format(pie-modal): DSW-1969 added comment for ticket to address
JoshuaNg2332 Jul 15, 2024
27a6e73
format(pie-button): DSW-1969 removed unneeded eslint line and updated…
JoshuaNg2332 Jul 15, 2024
619902f
Merge branch 'main' into DSW-1969-percy-cli-chrome-fix-5
JoshuaNg2332 Jul 15, 2024
0cc5d19
docs(pie-docs): DSW-1624 update pie-webc documentation for pie-docs (…
leksaBoiko Jul 16, 2024
bdda830
Merge branch 'main' into DSW-1969-percy-cli-chrome-fix-5
JoshuaNg2332 Jul 16, 2024
ada2869
chore(pie-monorepo): DSW-1969 updated percy/cli package
JoshuaNg2332 Jul 17, 2024
63709c3
Merge branch 'main' into DSW-1969-percy-cli-chrome-fix-5
JoshuaNg2332 Jul 17, 2024
f61b574
ci(pie-monorepo): DSW-1969 updated ci.yml for logging
JoshuaNg2332 Jul 18, 2024
2f960e1
ci(pie-monorepo): DSW-1969 percy debug env variables added
JoshuaNg2332 Jul 25, 2024
ba25292
feat(pie-checkbox-group): DSW-2182 main component functionality (#1581)
dandel10n Jul 18, 2024
6824d19
chore(deps): dsw-000 update dependency @babel/cli to v7.24.8 (#1602)
renovate[bot] Jul 18, 2024
3b6b293
chore(pie-monorepo): DSW-000 let commitizen read the ticket number fr…
xander-marjoram Jul 18, 2024
2cb6919
fix(pie-cookie-banner): WCP-1109 update cookie banner copy for en-FR …
xander-marjoram Jul 18, 2024
6cedb3c
feat(pie-monorepo): DSW-2056 added pie-webc integration to next 10 ex…
kevinrodrigues Jul 22, 2024
201307c
feat(pie-monorepo): DSW-2056 pie webc integration next13 (#1613)
kevinrodrigues Jul 22, 2024
776dc10
docs(pie-docs): DSW-2211 adding overview of web components (#1589)
maledr5 Jul 22, 2024
667b174
docs(pie-docs): DSW-2220 add overview page and assets (#1605)
leksaBoiko Jul 23, 2024
5df20f5
feat(pie-cookie-banner): DSW-2210 add entrance animation variants (#1…
xander-marjoram Jul 23, 2024
ebd078c
Version Packages (#1606)
pie-design-system-bot Jul 23, 2024
0483fff
feat(pie-monorepo): DSW-2056 integrate pie-webc into react18 examples…
kevinrodrigues Jul 23, 2024
bb4962b
chore(deps): dsw-000 update dependency @babel/core to v7.24.9 (#1620)
renovate[bot] Jul 24, 2024
04b380e
chore(deps): dsw-000 update actions/upload-artifact action to v4.3.4 …
renovate[bot] Jul 24, 2024
61c9cee
feat(pie-monorepo): DSW-2056 added pie-webc integration to react 17 e…
kevinrodrigues Jul 24, 2024
4223816
feat(pie-button): DSW-000 Changing styles to use classmap (#1587)
ashleynolan Jul 24, 2024
98dfca0
feat(pie-checkbox-group): DSW-2182 checkbox group styling (#1618)
dandel10n Jul 24, 2024
1fc27b0
feat(pie-webc): DSW-2182 isRtl attr changed to data-is-rtl (#1625)
dandel10n Jul 24, 2024
774a7ec
Version Packages (#1623)
pie-design-system-bot Jul 25, 2024
e7965d7
refactor(pie-monorepo): DSW-1969 updated tests and playwright packages
JoshuaNg2332 Jul 4, 2024
b1c800d
chore(pie-monorepo): DSW-1969 yarn update
JoshuaNg2332 Jul 12, 2024
70a3134
docs(pie-docs): DSW-1624 update pie-webc documentation for pie-docs (…
leksaBoiko Jul 16, 2024
e7d2e7a
chore(pie-monorepo): DSW-1969 updated percy/cli package
JoshuaNg2332 Jul 17, 2024
9571fb7
chore(pie-monorepo): DSW-1969 update yarn
JoshuaNg2332 Jul 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-chicken-allow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"pie-monorepo": patch
---

Updated Playwright and Percy CLI dependancies
13 changes: 7 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@
"@justeattakeaway/pie-webc-testing": "0.13.0",
"@justeattakeaway/pie-wrapper-react": "0.14.1",
"@justeattakeaway/stylelint-config-pie": "0.7.0",
"@percy/cli": "1.26.3",
"@percy/playwright": "1.0.4",
"@playwright/experimental-ct-react": "1.32.3",
"@playwright/test": "1.32.3",
"@percy/cli": "1.28.8",
"@percy/playwright": "1.0.5",
xander-marjoram marked this conversation as resolved.
Show resolved Hide resolved
"@playwright/experimental-ct-react": "1.41.0",
"@playwright/test": "1.41.0",
"@rollup/plugin-node-resolve": "15.1.0",
"@sand4rt/experimental-ct-web": "1.0.8",
"@sand4rt/experimental-ct-web": "1.41.0",
"@types/node": "20.4.8",
"@types/react": "18.3.3",
"@typescript-eslint/eslint-plugin": "5.62.0",
Expand Down Expand Up @@ -139,6 +139,7 @@
"resolutions": {
"@babel/traverse": "7.22.5",
"lit": "3.1.2",
"tar": "6.2.1"
"tar": "6.2.1",
"@playwright/experimental-ct-core": "1.41.0"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ test('should correctly work with native click events', async ({ mount }) => {
});

test.describe('Form Actions', () => {
test.beforeEach(async ({ mount }) => {
const component = await mount(PieButton);
await component.unmount();
});

test.describe('Submit', () => {
test('should correctly submit an HTML form when type is `submit`', async ({ page }) => {
// Arrange
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
WebComponentTestWrapper,
} from '@justeattakeaway/pie-webc-testing/src/helpers/components/web-component-test-wrapper/WebComponentTestWrapper.ts';
import { percyWidths } from '@justeattakeaway/pie-webc-testing/src/percy/breakpoints.ts';
import { PieButton } from '../../src/index.ts';
import { sizes } from '../../src/defs.ts';

const props: PropObject = {
Expand All @@ -28,8 +29,10 @@ const renderTestPieButton = (propVals: WebComponentPropValues) => `<pie-button s
const componentPropsMatrix : WebComponentPropValues[] = getAllPropCombinations(props);

// eslint-disable-next-line no-empty-pattern
test.beforeEach(async ({ }, testInfo) => {
test.beforeEach(async ({ mount }, testInfo) => {
xander-marjoram marked this conversation as resolved.
Show resolved Hide resolved
testInfo.setTimeout(testInfo.timeout + 40000);
const component = await mount(PieButton);
await component.unmount();
});

test('should render all size variations', async ({ page, mount }) => {
Expand Down
19 changes: 12 additions & 7 deletions packages/components/pie-modal/test/component/pie-modal.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ import {
let modalComponent: ModalComponent;

test.describe('modal', () => {
test.beforeEach(async ({ page }) => {
test.beforeEach(async ({ page, mount }) => {
modalComponent = new ModalComponent(page);
const component = await mount(PieModal);
await component.unmount();
});

test('should be visible when opened', async ({ mount }) => {
Expand Down Expand Up @@ -417,14 +419,17 @@ test.describe('modal', () => {
expect(isModalVisible).toBe(true);
});

test('should NOT close the modal when the Escape key is pressed', async ({ mount, page }) => {
test.skip('should NOT close the modal when the Escape key is pressed', async ({ mount, page }) => {
xander-marjoram marked this conversation as resolved.
Show resolved Hide resolved
// Arrange
await mount(PieModal, {
props: {
isOpen: true,
isDismissible: false,
await mount(
PieModal,
{
props: {
isOpen: true,
isDismissible: false,
},
},
});
);

// Act
await page.keyboard.press('Escape');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ const inputSelector = '[data-test-id="switch-input"]';
const switchLabelSelector = (placement: LabelPlacement = 'leading') => `[data-test-id="switch-label-${placement}"]`;

test.describe('Component: `Pie switch`', () => {
test.beforeEach(async ({ mount }) => {
const component = await mount(PieSwitch);
await component.unmount();
});

test('should be visible', async ({ mount, page }) => {
// Arrange
await mount(PieSwitch, {
Expand Down
Loading
Loading