-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pie-monorepo): DSW-1969 updated Playwright and Percy dependencies OLD #1600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9571fb7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
….0.8 (#1565) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… percy package to lts
#1609) * feat(pie-monorepo): DSW-2056 integrate pie-webc into react18 examples app and switch to vite * feat(pie-monorepo): DSW-2056 include lit react package * feat(pie-monorepo): DSW-2056 revert versioning number from new build * feat(pie-monorepo): DSW-2056 update package file to revert removed changes * feat(pie-monorepo): DSW-2056 pr comments --------- Co-authored-by: Xander Marjoram <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…1601) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
#1610) * feat(pie-monorepo): DSW-2056 added pie-webc integration to react 17 example app * feat(pie-monorepo): DSW-2056 remove react svg * feat(pie-monorepo): DSW-2056 adds back package json configs * feat(pie-monorepo): DSW-2056 pr comments * feat(pie-monorepo): DSW-2056 pr comments * feat(pie-monorepo): DSW-2056 yarn lock update --------- Co-authored-by: Xander Marjoram <[email protected]>
* refactor(pie-button): DSW-000 updated styles to use classmap * format(pie-button): DSW-000 formatting updates for PR comments * fix(pie-button): DSW-000 change loading attribute to class
* feat(pie-checkbox-group): DSW-2182 enabling/disabling children + aria attr updates * feat(pie-checkbox-group): DSW-2182 checkbox-group styling * feat(pie-webc): DSW-2182 isRtl attr changed to data-is-rtl
release: release packages with 'latest' tag Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…1585) * docs(pie-docs): DSW-1624 update pie-webc documentation for pie-docs * docs(pie-docs): DSW-1624 documented Next 13 apps conditions * fix(pie-docs): DSW-1624 fix spacing * fix(pie-docs): DSW-1624 changed imports * fix(pie-docs): DSW-1624 fix path for apps using Next 13 * fix(pie-docs): DSW-1624 import components individually for Next 13 --------- Co-authored-by: Xander Marjoram <[email protected]>
JoshuaNg2332
changed the title
fix(pie-monorepo): DSW-1969 updated Playwright and Percy dependencies
fix(pie-monorepo): DSW-1969 updated Playwright and Percy dependencies OLD
Jul 25, 2024
JoshuaNg2332
added
work-in-progress
This pull request is still a work in progress and may not be ready for review
DO NOT MERGE
labels
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apps
components
DO NOT MERGE
pie-button
pie-checkbox
pie-checkbox-group
pie-cookie-banner
pie-css
pie-docs
pie-form-label
pie-icons-react
pie-modal
pie-storybook
pie-switch
pie-webc
pie-webc-core
tools
work-in-progress
This pull request is still a work in progress and may not be ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
A couple things to note with this PR is that all screenshots added are now covering the Chrome browser.
Some differences in the screenshots of existing packages are due to the change of order in some of the listed variations.
Another note is there is 1 test that has been skipped. This seems to be a legitimate failure of the component test that is blocking this work so a ticket will be written to address this.
Author Checklist (complete before requesting a review)
PIE Storybook
/PIE Docs
PR previewReviewer checklists (complete before approving)
Reviewer 1 - @xander-marjoram
PIE Storybook
/PIE Docs
PR previewReviewer 2
PIE Storybook
/PIE Docs
PR preview