Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-monorepo): DSW-1969 updated Playwright and Percy dependencies OLD #1600

Closed
wants to merge 37 commits into from

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Jul 12, 2024

Describe your changes (can list changeset entries if preferable)

  • Updated Percy and Playwright dependencies
  • Updated tests to support updated Playwright deps

A couple things to note with this PR is that all screenshots added are now covering the Chrome browser.
Some differences in the screenshots of existing packages are due to the change of order in some of the listed variations.

Another note is there is 1 test that has been skipped. This seems to be a legitimate failure of the component test that is blocking this work so a ticket will be written to address this.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving

Reviewer checklists (complete before approving)

Reviewer 1 - @xander-marjoram

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners July 12, 2024 15:19
Copy link

changeset-bot bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: 9571fb7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Jul 12, 2024


Fails
🚫 You currently have an unchecked checklist item in your PR description.

Please confirm this check has been carried out – if it's not relevant to your PR, delete this line from the PR checklist.

Generated by 🚫 dangerJS against f61b574

package.json Outdated Show resolved Hide resolved
kevinrodrigues and others added 13 commits July 25, 2024 12:44
#1609)

* feat(pie-monorepo): DSW-2056 integrate pie-webc into react18 examples app and switch to vite

* feat(pie-monorepo): DSW-2056 include lit react package

* feat(pie-monorepo): DSW-2056 revert versioning number from new build

* feat(pie-monorepo): DSW-2056 update package file to revert removed changes

* feat(pie-monorepo): DSW-2056 pr comments

---------

Co-authored-by: Xander Marjoram <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…1601)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
#1610)

* feat(pie-monorepo): DSW-2056 added pie-webc integration to react 17 example app

* feat(pie-monorepo): DSW-2056 remove react svg

* feat(pie-monorepo): DSW-2056 adds back package json configs

* feat(pie-monorepo): DSW-2056 pr comments

* feat(pie-monorepo): DSW-2056 pr comments

* feat(pie-monorepo): DSW-2056 yarn lock update

---------

Co-authored-by: Xander Marjoram <[email protected]>
* refactor(pie-button): DSW-000 updated styles to use classmap

* format(pie-button): DSW-000 formatting updates for PR comments

* fix(pie-button): DSW-000 change loading attribute to class
* feat(pie-checkbox-group): DSW-2182 enabling/disabling children + aria attr updates

* feat(pie-checkbox-group): DSW-2182 checkbox-group styling

* feat(pie-webc): DSW-2182 isRtl attr changed to data-is-rtl
release: release packages with 'latest' tag

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…1585)

* docs(pie-docs): DSW-1624 update pie-webc documentation for pie-docs

* docs(pie-docs): DSW-1624 documented Next 13 apps conditions

* fix(pie-docs): DSW-1624 fix spacing

* fix(pie-docs): DSW-1624 changed imports

* fix(pie-docs): DSW-1624 fix path for apps using Next 13

* fix(pie-docs): DSW-1624 import components individually for Next 13

---------

Co-authored-by: Xander Marjoram <[email protected]>
@JoshuaNg2332 JoshuaNg2332 changed the title fix(pie-monorepo): DSW-1969 updated Playwright and Percy dependencies fix(pie-monorepo): DSW-1969 updated Playwright and Percy dependencies OLD Jul 25, 2024
@JoshuaNg2332 JoshuaNg2332 added work-in-progress This pull request is still a work in progress and may not be ready for review DO NOT MERGE labels Jul 25, 2024
@JoshuaNg2332 JoshuaNg2332 deleted the DSW-1969-percy-cli-chrome-fix-5 branch August 2, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants