-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pie-monorepo): DSW-1823 update PR template to be dynamic based on scope of change #1345
Conversation
|
Could we have a quick catchup on this before it's merged – I think me and @xander-marjoram may have had a bit of feedback that's worth including (mine isn't big – but could be a small improvement) |
a2b60c8
to
2fa8f02
Compare
I like the flexibility this approach gives us (and it's a neat trick using the links to particular templates), but I wonder if it is adding complexity when it might not need to be added. I've had an idea that we could use something like Danger to check whether there are component/docs/storybook changes and dynamically create a comment with a checklist for the author and reviewers to complete. I think it would be a bit more involved to create, but I think the developer experience would end up being a bit nicer and there would hopefully be less room for error in terms of making sure the template has good coverage, as there may end up being PRs that update a component and the docs site at the same time, for example. |
@xander-marjoram @siggerzz Totally agree – I think we should merge this and then iterate on it to improve it with that sort of functionality. I imagine we'd need to use a custom Github action to add comments like that (not sure Danger would be able to do it from my experience with it) and all should be possible, but best to merge this and iterate on it. |
…on scope of change
e51c154
to
3e74bfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!!!
Describe your changes (can list changeset entries if preferable)
This functionality won't be live on the origin PIE repo until the templates are in main, but I've tested this functionality in my fork, and you can see it in action here
Author Checklist (complete before requesting a review)