-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(pie-monorepo): DSW-1823 update PR template to be dynamic based …
…on scope of change (#1345) * feat(pie-monorepo): DSW-1823 test pr templates * chore(pie-monorepo): DSW-1823 update PR template to be dynamic based on scope of change * chore(pie-monorepo): DSW-1823 update templates * chore(pie-monorepo): DSW-1823 update yarn lock * chore(pie-monorepo): DSW-1823 fix yarn lock * fix rebase * chore(pie-monorepo): DSW-1823 update template * chore(pie-monorepo): DSW-1823 update template * chore(pie-monorepo): DSW-1823 change format * chore(pie-monorepo): DSW-1823 update wording * chore(pie-monorepo): DSW-1823 rebase * chore(pie-monorepo): DSW-1823 correct changes * format(pie-monorepo): DSW-1823 remove periods * chore(pie-monorepo): DSW-1823 pR suggestions * chore(pie-monorepo): DSW-1823 add link to label creation page
- Loading branch information
Showing
4 changed files
with
63 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
## Describe your changes (can list changeset entries if preferable) | ||
|
||
|
||
## Author Checklist (complete before requesting a review) | ||
- [ ] I have performed a self-review of my code | ||
- [ ] I have added thorough tests where applicable (unit / component / visual) | ||
- [ ] I have reviewed the Docs site preview | ||
- [ ] If there are visual test updates, I have reviewed them properly before approving | ||
|
||
## Reviewer checklists (complete before approving) | ||
### Reviewer 1 | ||
- [ ] I have reviewed the Docs site preview | ||
- [ ] If new links have been added, I have tested them in the preview | ||
- [ ] If there are visual test updates, I have reviewed them | ||
|
||
### Reviewer 2 | ||
- [ ] I have reviewed the Docs site preview | ||
- [ ] If new links have been added, I have tested them in the preview | ||
- [ ] If there are visual test updates, I have reviewed them |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
## Describe your changes (can list changeset entries if preferable) | ||
|
||
|
||
## Author Checklist (complete before requesting a review) | ||
- [ ] I have performed a self-review of my code | ||
- [ ] I have added thorough tests where applicable (unit / component / visual) | ||
- [ ] If visual tests are required for the component, I have created a project in Percy | ||
- [ ] I have reviewed the `PIE Storybook`/`PIE Docs` PR preview | ||
- [ ] I have reviewed visual test updates properly before approving | ||
- [ ] If changes will affect consumers of the package, I have created a changeset entry. | ||
- [ ] If a changeset file has been created, I have used the `/snapit` functionality to test my changes in a consuming application | ||
- [ ] I have [created a new label](https://github.com/justeattakeaway/pie/issues/labels) and added it to the [PR Labeler workflow](https://github.com/justeattakeaway/pie/blob/main/.github/project-labeler.yml) | ||
|
||
## Reviewer checklists (complete before approving) | ||
### Reviewer 1 | ||
- [ ] I have reviewed the `PIE Storybook`/`PIE Docs` PR preview | ||
- [ ] If there are visual test updates, I have reviewed them | ||
|
||
### Reviewer 2 | ||
- [ ] I have reviewed the `PIE Storybook`/`PIE Docs` PR preview | ||
- [ ] If there are visual test updates, I have reviewed them |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,26 @@ | ||
Please click the `Preview` tab and select a different PR template if your change isn't for an existing web component. | ||
|
||
[PIE Docs Template](?expand=1&template=docs_template.md) | ||
[New Web Component Template](?expand=1&template=new_component_template.md) | ||
|
||
═══════════════════════════════════════════════════════════ | ||
|
||
## Describe your changes (can list changeset entries if preferable) | ||
|
||
|
||
## Author Checklist (complete before requesting a review) | ||
- [ ] I have performed a self-review of my code | ||
- [ ] If it is a core feature, I have added thorough tests | ||
- [ ] If it is a `PIE Docs` change, I have reviewed the Docs site preview | ||
- [ ] If it is a component change, I have reviewed the Storybook preview | ||
- [ ] If there are visual test updates, I have reviewed them properly before approving | ||
- [ ] I have added thorough tests where applicable (unit / component / visual) | ||
- [ ] I have reviewed the `PIE Storybook`/`PIE Docs` PR preview | ||
- [ ] I have reviewed visual test updates properly before approving | ||
- [ ] If changes will affect consumers of the package, I have created a changeset entry. | ||
- [ ] If a changeset file has been created, I have used the `/snapit` functionality to test my changes in a consuming application | ||
|
||
## Reviewer checklists (complete before approving) | ||
### Reviewer 1 | ||
- [ ] If it is a `PIE Docs` change, I have reviewed the PR preview | ||
- [ ] I have reviewed the `PIE Storybook`/`PIE Docs` PR preview | ||
- [ ] If there are visual test updates, I have reviewed them | ||
|
||
### Reviewer 2 | ||
- [ ] If it is a `PIE Docs` change, I have reviewed the PR preview | ||
- [ ] I have reviewed the `PIE Storybook`/`PIE Docs` PR preview | ||
- [ ] If there are visual test updates, I have reviewed them |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters