refactor: removed basilisk feature #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inventvenkat
added
the
S-waiting-on-review
inventvenkat
requested review from
jarnura,
SanchithHegde and
sai-harsha-vardhan
inventvenkat
force-pushed
the
removal/temp_locker
branch
from
a255c09 to
f45fd84
Compare
SanchithHegde
previously approved these changes
Jan 9, 2024
srujanchikke
previously approved these changes
Jan 9, 2024
|
Can you check and remove these variables from config |
15 tasks
inventvenkat
dismissed stale reviews from srujanchikke and SanchithHegde
via
076c905
|
Removed the basilisk related variables |
dracarys18
approved these changes
Jan 10, 2024
jarnura
approved these changes
Jan 10, 2024
SanchithHegde
approved these changes
Jan 10, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 11, 2024
* 'main' of github.com:juspay/hyperswitch: ci: use git commands for pushing commits and tags in nightly release workflows (#3314) refactor(connector): [bluesnap] add connector_txn_id fallback for webhook (#3315) feat(core): add new payments webhook events (#3212) chore: nits and small code improvements found during investigation of PR#3168 (#3259) refactor: removed basilisk feature (#3281) fix(euclid_wasm): Update braintree config prod (#3288) feat(payment_link): add status page for payment link (#3213) chore(version): 2024.01.10.0 chore(postman): update Postman collection files
pixincreate
added
A-core
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Removed temp locker related feature. Feature basilisk is used for temp locker and I removed it since it is not used as main source. We are now using Redis for storing temporarily
Additional Changes
Motivation and Context
How did you test it?
Tested generic flows and temp locker usage flows, in sandbox.
Checklist
cargo +nightly fmt --allcargo clippy