Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed basilisk feature #3300

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

inventvenkat
Copy link
Contributor

@inventvenkat inventvenkat commented Jan 10, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removed temp locker related feature. Feature basilisk is used for temp locker and I removed it since it is not used as main source. We are now using Redis for storing temporarily

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  1. Removed temp locker flow from the application. We already started using redis in place. Temp locker was used as fallback.
  2. Reduction in resource.
  3. reduction in code to make it clean

How did you test it?

Removed only redundant code.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Hotfix PR to main branch: #3281

@inventvenkat inventvenkat added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 10, 2024
@inventvenkat inventvenkat self-assigned this Jan 10, 2024
@inventvenkat inventvenkat requested review from a team as code owners January 10, 2024 05:46
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 10, 2024
@inventvenkat inventvenkat changed the title Remove/basiliskv3 hotfix refactor: removed basilisk feature Jan 10, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 10, 2024
@inventvenkat inventvenkat merged commit e6f0c99 into hotfix-1.105.0 Jan 10, 2024
13 of 18 checks passed
@inventvenkat inventvenkat deleted the remove/basiliskv3_hotfix branch January 10, 2024 10:54
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants