Add Utilities.sorted_list_of_model_attributes #2371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Dec 20, 2023
odow
force-pushed
the
od/SortedListOfModelAttributesSet
branch
from
0931bd8
to
82dacaa
Compare
|
Looking into why Juniper started to fail tests |
|
So this issue is that Juniper defines a bunch of model filters: |
odow
changed the title
odow
commented
Dec 21, 2023
| @@ -9,9 +9,39 @@ | |||
|
|
|||
| include("copy/index_map.jl") | |||
|
|
|||
| _sort_priority(::Any) = 2 | |||
| _sort_priority(::MOI.UserDefinedFunction) = 0 | |||
| _sort_priority(::MOI.ObjectiveSense) = 1 | |||
There was a problem hiding this comment.
So in retrospect, all this PR really needed was _sort_priority(::Any) = 3 and _sort_priority(::MOI.ObjectiveFunction) = 2.
Do we want to make this all public?
There was a problem hiding this comment.
I would do this simple fix, and reopen this PR if this keeps coming back and someone actually needs to extend this kind of methods.
|
Closing in favor of #2372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2366
Closes #2369
https://github.com/jump-dev/MathOptInterface.jl/actions/runs/7282138662