Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use json-smart to parse the query #314

Merged

Conversation

jochenberger
Copy link
Contributor

As I see it, the JsonProvider is only responsible to read the data, not the query.
See also #305, #275, but also #274.

@jochenberger
Copy link
Contributor Author

I guess, `JsonNode' shouldn't use the provider at all.

@jochenberger
Copy link
Contributor Author

This reverts parts of #101

@kallestenflo
Copy link
Contributor

Is this the only reason for JsonSmart to be a mandatory dependency?

@jochenberger
Copy link
Contributor Author

IMHO, Using json-smart as the default provider makes it a mandatory dependency, otherwise we ship a broken default config, don't we?

@jochenberger
Copy link
Contributor Author

In the build.gradle, the dependency is mandatory already. I must admit though that I don't know anything about the whole OSGi topic.

@kallestenflo
Copy link
Contributor

I think it's common to exlude JsonSmart in some scenarios like Android. The main reason for this has been the ASM issues in JsonSmart. That should not be an issue now?

@jochenberger
Copy link
Contributor Author

Yes, that should be dealt with in #334.
But excluding the dependency and marking the classes as optional in the OSGi manifest are two different things. I'm just not away of the effects of the latter.

@kallestenflo kallestenflo merged commit 455103e into json-path:master Mar 29, 2017
@jochenberger jochenberger deleted the use-json-smart-for-query-parsing branch March 29, 2017 08:39
cmunilla pushed a commit to cmunilla/JPath that referenced this pull request Oct 30, 2017
…-query-parsing

use json-smart to parse the query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants