Regression in JacksonJsonNodeJsonProvider

[trustin]

Given the following document:

[
  {
    "name": "a",
    "groups": [{
      "type": "phase",
      "name": "alpha"
    }, {
      "type": "not_phase",
      "name": "beta"
    }]
  }, {
    "name": "b",
    "groups": [{
      "type": "phase",
      "name": "beta"
    }, {
      "type": "not_phase",
      "name": "alpha"
    }]
  }
]

and the following JSON path query:

$[?(@.groups[?(@.type == 'phase' && @.name == 'alpha')] empty false)]

2.2.0 and 2.3.0 yield different results:

// 2.2.0 (selects 'a'):
[
  {
    "name": "a",
    "groups": [{
      "type": "phase",
      "name": "alpha"
    }, {
      "type": "not_phase",
      "name": "beta"
    }]
  }
]
// 2.3.0 (selects none):
[]

[jochenberger]

I can't reproduce the issue. I get the same result with 2.2.0 and 2.3.0. Can you share some more details?

[trustin]

That's weird. Let me dig further and get back to you.

[trustin]

Could you try this?

import org.junit.Test;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.jayway.jsonpath.Configuration;
import com.jayway.jsonpath.JsonPath;
import com.jayway.jsonpath.spi.json.JacksonJsonNodeJsonProvider;
import com.jayway.jsonpath.spi.mapper.JacksonMappingProvider;

public class Regression366 {
    @Test
    public void regression() throws Exception {
        JsonNode instance = new ObjectMapper().readTree(
                '[' +
                "  {" +
                "    \"name\": \"a\"," +
                "    \"groups\": [{" +
                "      \"type\": \"phase\"," +
                "      \"name\": \"alpha\"" +
                "    }, {" +
                "      \"type\": \"not_phase\"," +
                "      \"name\": \"beta\"" +
                "    }]" +
                "  }, {" +
                "    \"name\": \"b\"," +
                "    \"groups\": [{" +
                "      \"type\": \"phase\"," +
                "      \"name\": \"beta\"" +
                "    }, {" +
                "      \"type\": \"not_phase\"," +
                "      \"name\": \"alpha\"" +
                "    }]" +
                "  }" +
                ']');

        Configuration jsonPathConf =
                Configuration.builder()
                             .jsonProvider(new JacksonJsonNodeJsonProvider(new ObjectMapper()))
                             .mappingProvider(new JacksonMappingProvider(new ObjectMapper())).build();

        // Should not print '[]'
        System.err.println(
                JsonPath.parse(instance, jsonPathConf)
                        .read(JsonPath.compile(
                                "$[?(@.groups[?(@.type == 'phase' && @.name == 'alpha')] empty false)]"),
                              JsonNode.class));
    }
}

[trustin]

It seems like the following queries did not regress though:

• $[?(@.name == 'b')]
• $..groups[?(@.type == 'not_phase' && @.name == 'alpha')]

.. making me guess that there's something going wrong with nested queries.

[jochenberger]

It seems to be related to the JacksonJsonNodeJsonProvider:

 String json = "[  {    \"name\": \"a\",    \"groups\": [{      \"type\": \"phase\","
        + "      \"name\": \"alpha\"    }, {      \"type\": \"not_phase\",      \"name\": \"beta\""
        + "    }]  }, {    \"name\": \"b\",    \"groups\": [{      \"type\": \"phase\","
        + "      \"name\": \"beta\"    }, {      \"type\": \"not_phase\",      \"name\": \"alpha\"" + "    }]  }]";

    // Should not print '[]'
    System.err.println(JsonPath.parse(json)
        .read(JsonPath.compile("$[?(@.groups[?(@.type == 'phase' && @.name == 'alpha')] empty false)]")));

yields the same result with 2.2.0 and 2.3.0.
So does

String json = "[  {    \"name\": \"a\",    \"groups\": [{      \"type\": \"phase\","
        + "      \"name\": \"alpha\"    }, {      \"type\": \"not_phase\",      \"name\": \"beta\""
        + "    }]  }, {    \"name\": \"b\",    \"groups\": [{      \"type\": \"phase\","
        + "      \"name\": \"beta\"    }, {      \"type\": \"not_phase\",      \"name\": \"alpha\"" + "    }]  }]";

    Configuration jsonPathConf = Configuration.builder().jsonProvider(new JacksonJsonProvider(new ObjectMapper()))
        .mappingProvider(new JacksonMappingProvider(new ObjectMapper())).build();

    // Should not print '[]'
    System.err.println(JsonPath.using(jsonPathConf).parse(json)
        .read(JsonPath.compile("$[?(@.groups[?(@.type == 'phase' && @.name == 'alpha')] empty false)]")));

[jochenberger]

6cf30fd/#314 broke it

[trustin]

Thanks a lot for a super quick fix! Any chance of cutting a new release?