Release: Make Sizzle work with jquery-release, remove generated files #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Mar 1, 2020
Running `grunt` will now just build Sizzle, do a size comparison & run ESLint, similarly to what we do in jQuery. `grunt test` is used to run unit tests and it requires running `grunt` or `grunt build` before to generate the built Sizzle version. Fixes jquerygh-239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes, divided into three commits here:
gruntIt turns out jquery-release already allows one to skip the CDN part of the release so it was possible to remove overriding private
Releasemethods.I did a release on the branch with
--dry-runand the output looked correct to me.Fixes gh-239