Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate locally-built sizzle files from released code #239

Closed
gibson042 opened this issue Jan 6, 2014 · 5 comments · Fixed by #467
Closed

Isolate locally-built sizzle files from released code #239

gibson042 opened this issue Jan 6, 2014 · 5 comments · Fixed by #467
Milestone
2.3.5

Comments

@gibson042
Copy link
Member

Since dist/sizzle* are included in the repo, every grunt tends to force the working directory into a dirty state, disrupting size comparison and making pull requests less straightforward. We should update the build, testing, and/or release processes to isolate locally-built output from tagged releases, either through separate "build" and "dist" locations or through special release commits that diverge from the master branch.
@mgol
Copy link
Member

mgol commented Jan 6, 2014

Why are those files included in the first place? It makes diffs unnecessarily large.

@gibson042
Copy link
Member Author

As I understand it, bower requires release files to appear in tagged commits. We got that quickly and for free by just adding them to the repository, but I'd like to spend some time on improving the process (hence this ticket).

@timmywil
Copy link
Member

timmywil commented Jan 6, 2014

We could do the same thing we do in jQuery core and include distribution files solely on headless tagged commits.

@timmywil
Copy link
Member

timmywil commented Jan 6, 2014

The current setup is just the quick and dirty solution.

gibson042 added a commit to gibson042/sizzle that referenced this issue Oct 26, 2018
@gibson042
Release: Add jquery-release script
37bd7c3 
Ref jquerygh-239
Ref jquerygh-308
@gibson042 gibson042 mentioned this issue Oct 26, 2018
Merged
mgol pushed a commit that referenced this issue Jan 14, 2019
@gibson042 @mgol
Release: Add jquery-release script
686f08d 
Ref gh-239
Ref gh-308
Closes gh-433
@mgol mgol mentioned this issue Mar 1, 2020
Merged
mgol added a commit to mgol/sizzle that referenced this issue Mar 1, 2020
@mgol
Build: Don't run tests on grunt
6d76c1b 
Running `grunt` will now just build Sizzle, do a size comparison & run ESLint,
similarly to what we do in jQuery. `grunt test` is used to run unit tests and
it requires running `grunt` or `grunt build` before to generate the built Sizzle
version.

Fixes jquerygh-239
@mgol
Copy link
Member

mgol commented Mar 1, 2020

PR: #467

@mgol mgol added this to the 2.3.5 milestone Mar 1, 2020
@mgol mgol closed this as completed in #467 Mar 2, 2020
mgol added a commit that referenced this issue Mar 2, 2020
@mgol
Release: Make Sizzle work with jquery-release, remove generated files
096f683 
Running `grunt` will now just build Sizzle, do a size comparison & run ESLint,
similarly to what we do in jQuery. `grunt test` is used to run unit tests and
it requires running `grunt` or `grunt build` before to generate the built
Sizzle version.

Fixes gh-239
Closes gh-467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.3.5
Development

Successfully merging a pull request may close this issue.

Release: Make Sizzle work with jquery-release, remove generated files mgol/sizzle
3 participants
@timmywil @gibson042 @mgol