-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Deserializes.php Timezone problems #746
Conversation
Fix assuming the wrong timezone when converting DateTime values ending with "Z"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test would be great :) preferably on the endpoint where you found the error!
@simonsolutions happy to merge this as soon as you push a test. A good test for this would check if a datetime string with a timezone specifier (like |
Add deserialize test with Timezone
Now added a simple deserialize sample with timezone. |
Add additionally checking the right timezone
Sorry missed a bracket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added missing bracket
API for deliveryWindowOptions returning date as 2024-08-12T00:00Z which causes the unknown DateTime format exception. |
@zaineco could you share a debug log from calling the endpoint that's giving you the exception? Just call |
@jlevers, the following is response log for ListDeliveryWindowOptions endpoint
|
Thanks – that should be fixed in |
Fix assuming the wrong timezone when converting DateTime values ending with "Z".