Fixes https://github.com/jlevers/selling-partner-api/issues/758 #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know I'm not supposed to edit this. But this is the only way I could think of.
|
Removing the DateTime Deserialize function isn't a good idea i suppose. The question would be what datetime format is delivered in the api response that could possibly be taken into account of the function to deserialize. |
|
Referring to PR #746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look. I'm not great at coding. But this works.
It allows
SellingPartnerApi->seller()->catalogItems->catalogApi->getCatalogItem()to work, getting around the 'datetime cannot be false' issue via the use of 'Union' types.Accepting this PR would probably break a lot of things that I'm not aware of.
But it doesn't give me any errors.
So I'm putting this here, so other coders can add to this.