Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase consent check and inactivity intervals. #2044

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Aug 23, 2023

  • Bump consent check and inactivity intervals.
  • Add missing whitespace in reference.conf.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2044 (ceb48c2) into master (1a86219) will increase coverage by 0.26%.
Report is 2 commits behind head on master.
The diff coverage is 5.26%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2044      +/-   ##
============================================
+ Coverage     42.48%   42.75%   +0.26%     
- Complexity     1677     1684       +7     
============================================
  Files           325      325              
  Lines         17127    17144      +17     
  Branches       2252     2253       +1     
============================================
+ Hits           7277     7330      +53     
+ Misses         9141     9098      -43     
- Partials        709      716       +7     
Files Changed Coverage Δ
...ia/rtp/remotebitrateestimator/OveruseDetector.java 82.25% <0.00%> (-1.35%) ⬇️
...teestimator/RemoteBitrateEstimatorAbsSendTime.java 64.54% <0.00%> (-7.18%) ⬇️
...i/nlj/rtp/bandwidthestimation/GoogleCcEstimator.kt 50.84% <0.00%> (-4.71%) ⬇️
...dia/rtp/remotebitrateestimator/BandwidthUsage.java 83.33% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb3315...ceb48c2. Read the comment docs.

@@ -1,54 +1,54 @@
videobridge {
entity-expiration {
# If an entity has no activity after this timeout, it is expired
timeout=1 minute
timeout =1 minute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're adding whitespace this should have whitespace on both sides of the equal sign

@bgrozev bgrozev marked this pull request as ready for review August 23, 2023 22:40
@bgrozev bgrozev merged commit a8d8a78 into jitsi:master Aug 24, 2023
3 of 5 checks passed
@bgrozev bgrozev deleted the increase-consent-check-interval branch May 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants