Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): add localSubject and subject as authentication options #14554

Closed
wants to merge 6 commits into from
Closed

feat(authentication): add localSubject and subject as authentication options #14554

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64b7ddf
feat(authentication): add localSubject and subject as authentication …
Calinteodor Mar 27, 2024
7a87b01
feat(authentication): fixed linter
Calinteodor Mar 27, 2024
cfebeb2
feat(authentication): removed comma
Calinteodor Mar 27, 2024
7ce9859
feat(authentication): removed extra empty space
Calinteodor Mar 27, 2024
0b6b35c
feat(authentication): fixed linter
Calinteodor Mar 27, 2024
cbec95e
feat(authentication): revert authentication changes
Calinteodor Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions react/features/base/conference/reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,10 +596,7 @@ function _setRoom(state: IConferenceState, action: AnyAction) {
*/
return assign(state, {
error: undefined,
localSubject: undefined,
pendingSubjectChange: undefined,
room,
subject: undefined
room
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you drop these? Isn't this rest of state when room changes in mobile? Especially the pendingSubjectChange.

Copy link
Contributor Author

@Calinteodor Calinteodor Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SET_ROOM here is triggered when we get back to the mobile app, joining the conference, after external authentication is complete. We don't want to set all of these to undefined, because if we do that subject and localSubject will be reset.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about pendingSubjectChange?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there is no auth and a user joins a different meeting? That's the problem that code tries to solve.

}

Loading