feat(authentication): add localSubject and subject as authentication options #14554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinteodor
requested review from
saghul and
damencho
and removed request for
saghul
damencho
reviewed
Mar 27, 2024
| pendingSubjectChange: undefined, | ||
| room, | ||
| subject: undefined | ||
| room | ||
| }); |
There was a problem hiding this comment.
Why do you drop these? Isn't this rest of state when room changes in mobile? Especially the pendingSubjectChange.
There was a problem hiding this comment.
SET_ROOM here is triggered when we get back to the mobile app, joining the conference, after external authentication is complete. We don't want to set all of these to undefined, because if we do that subject and localSubject will be reset.
There was a problem hiding this comment.
What about pendingSubjectChange?
There was a problem hiding this comment.
What if there is no auth and a user joins a different meeting? That's the problem that code tries to solve.
|
You need to update config.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.