Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to leave when the only remaining participants are hidden #537

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Fix failure to leave when the only remaining participants are hidden #537

merged 5 commits into from
Feb 20, 2024

Commits on Feb 19, 2024

  1. ref: Inline conference.memberCount.

    @bgrozev
    bgrozev committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2238777 View commit details
    Browse the repository at this point in the history

  2. fix: Exclude hidden participants from muted/jigasi count. 

    Fixes failure to leave when the only remaining participants are hidden
(for example, a transcriber).
    @bgrozev
    bgrozev committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5dfba31 View commit details
    Browse the repository at this point in the history

  3. ref: Simplify condition (jibri is always a recorder).

    @bgrozev
    bgrozev committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0dcf8e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. squash: Fix hidden participant filter. 

    hidden and hiddenFromRecorder are independent. We don't have a case
where a participant is hidden, but not hidden from recorder, but we do
have a case where a participant is only hidden from the recorder.
    @bgrozev
    bgrozev committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    7323325 View commit details
    Browse the repository at this point in the history

  2. squash: Log number of hidden participants.

    @bgrozev
    bgrozev committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    570cd80 View commit details
    Browse the repository at this point in the history