Fix failure to leave when the only remaining participants are hidden #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgrozev
commented
Feb 19, 2024
bgrozev
commented
- ref: Inline conference.memberCount.
- fix: Exclude hidden participants from muted/jigasi count.
Fixes failure to leave when the only remaining participants are hidden (for example, a transcriber).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
=========================================
Coverage 48.18% 48.18%
Complexity 174 174
=========================================
Files 72 72
Lines 2117 2117
Branches 201 201
=========================================
Hits 1020 1020
Misses 1029 1029
Partials 68 68
Continue to review full report in Codecov by Sentry.
|
hidden and hiddenFromRecorder are independent. We don't have a case where a participant is hidden, but not hidden from recorder, but we do have a case where a participant is only hidden from the recorder.
damencho
previously approved these changes
Feb 20, 2024
damencho
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.