-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing, remove deprecated RelatedLinkColumn #974
Open
jieter
wants to merge
14
commits into
master
Choose a base branch
from
feature/util-typing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieter
force-pushed
the
feature/util-typing
branch
from
December 21, 2024 10:14
5e4cec8
to
88f7317
Compare
jieter
force-pushed
the
feature/util-typing
branch
from
December 21, 2024 13:37
f501b82
to
0f7e5be
Compare
jieter
force-pushed
the
feature/util-typing
branch
from
December 23, 2024 08:37
b739c27
to
555071a
Compare
With pyupgrade it should be easy to move from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing union types as
X | Y
is first added in python 3.10, if we keep supporting it until the end of life of python 3.9, that would mean we can only merge this after 2025-10.Alternatively, we can use the
Union[X, Y]
syntax which is already supported by python 3.9.Another issue is
Unpack
which is available from python 3.11. It is part of typing_extensions, so we can still use it.The final few errors in the current state of this PR is this list (in which the tests are not yet included in the type checking):
Ideally, users of django-tables2 should still be able to use
def render(self, record)
ordef render(self, value)
without complaints of the type checker. I think this might be hard to achieve, so we should document that usingdef render(self, **kwargs: Unpack[CellArguments])
and unpacking kwargs in the body of the method is the way to achieve type safety.