Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rxdart dependency to 0.28.0 in alice package #235

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Update rxdart dependency to 0.28.0 in alice package #235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d70af2b
Update rxdart dependency to 0.28.0 in alice package
DDavidPrime Sep 5, 2024
fec1cd9
Revert path change in alice_calls_list_page
DDavidPrime Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/alice/lib/ui/calls_list/page/alice_calls_list_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,9 @@ class _AliceCallsListPageState extends State<AliceCallsListPage>
? context.i18n(AliceTranslationKey.saveSuccessView)
: null,
secondButtonAction: () =>
OperatingSystem.isAndroid ? OpenFilex.open(result.path) : null,
OperatingSystem.isAndroid && result.path != null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be part of this PR and is already being addressed in #229

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! Do we know when this will be merged?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "this"? 😅 This PR here or #229?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally both, but I meant this specific PR. Sorry for not being specific. 🙃

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will probably have to come after #229 as without it the CI won't be able to deploy it.

Obviously, I can't approve my own PR (#229) so we'll have to wait on @jhomlala to approve it.

? OpenFilex.open(result.path!)
: null,
);
} else {
final [String title, String description] = switch (result.error) {
Expand Down
2 changes: 1 addition & 1 deletion packages/alice/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies:
flutter:
sdk: flutter
flutter_local_notifications: ^17.1.2
rxdart: ^0.27.7
rxdart: ^0.28.0
path_provider: ^2.1.3
permission_handler: ^11.3.1
package_info_plus: ^8.0.0
Expand Down