Update rxdart dependency to 0.28.0 in alice package #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techouse
requested changes
Sep 6, 2024
| @@ -267,7 +267,9 @@ class _AliceCallsListPageState extends State<AliceCallsListPage> | |||
| ? context.i18n(AliceTranslationKey.saveSuccessView) | |||
| : null, | |||
| secondButtonAction: () => | |||
| OperatingSystem.isAndroid ? OpenFilex.open(result.path) : null, | |||
| OperatingSystem.isAndroid && result.path != null | |||
There was a problem hiding this comment.
This shouldn't be part of this PR and is already being addressed in #229
There was a problem hiding this comment.
Updated! Do we know when this will be merged?
There was a problem hiding this comment.
What do you mean by "this"? 😅 This PR here or #229?
There was a problem hiding this comment.
Ideally both, but I meant this specific PR. Sorry for not being specific. 🙃
jhomlala
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #234 , I've taken the time to create a PR for this. Let me know if there's anything else I should address if this is something that will be merged.