Jacoco coverrage Threshold rouding error #10900
Merged
+27
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
reviewed
Sep 18, 2024
| @@ -1292,7 +1292,7 @@ | |||
| <element>CLASS</element> | |||
| <limits> | |||
| <limit> | |||
| <counter>LINE</counter> | |||
| <counter>BRANCH</counter> | |||
There was a problem hiding this comment.
Then it becomes a duplicated limit of the limit that is defined below
There was a problem hiding this comment.
so what's your suggestion?
There was a problem hiding this comment.
I don't know, I've not done any investigation to fix the mentioned issue.
I'm just noticing that this limit is already defined.
Maybe @DamnClin know better.
There was a problem hiding this comment.
The idea is to go from
<value>COVEREDRATIO</value>
<minimum>1.00</minimum>
To
<value>MISSEDCOUNT</value>
<maximum>0</maximum>
For both banch and line, I missed copy past in the ticket, forgot to remove the failing part...
There was a problem hiding this comment.
@qmonmert : That means COVEREDRATIO limits should be removed
qmonmert
force-pushed
the
fix/10752
branch
3 times, most recently
from
7eeaa21
to
fb9962a
Compare
DamnClin
reviewed
Sep 22, 2024
| value = "COVEREDRATIO" | ||
| minimum = "1.00".toBigDecimal() | ||
| value = "MISSEDCOUNT" | ||
| maximum = "1.00".toBigDecimal() |
DamnClin
reviewed
Sep 22, 2024
| value = "COVEREDRATIO" | ||
| minimum = "1.00".toBigDecimal() | ||
| value = "MISSEDCOUNT" | ||
| maximum = "1.00".toBigDecimal() |
DamnClin
reviewed
Sep 22, 2024
| value = "COVEREDRATIO" | ||
| minimum = "1.00".toBigDecimal() | ||
| value = "MISSEDCOUNT" | ||
| maximum = "1.00".toBigDecimal() |
DamnClin
reviewed
Sep 22, 2024
| value = "COVEREDRATIO" | ||
| minimum = "1.00".toBigDecimal() | ||
| value = "MISSEDCOUNT" | ||
| maximum = "1.00".toBigDecimal() |
DamnClin
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10752