Merge pull request #10900 from qmonmert/fix/10752

Jacoco coverrage Threshold rouding error
jhipster · Sep 22, 2024 · 1d17c26 · 1d17c26
2 parents 4911234 + a00c459
commit 1d17c26
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 27 deletions.
diff --git a/pom.xml b/pom.xml
@@ -1292,14 +1292,14 @@
                       <element>CLASS</element>
                       <limits>
                         <limit>
-                          <counter>LINE</counter>
-                          <value>COVEREDRATIO</value>
-                          <minimum>1.00</minimum>
+                          <counter>BRANCH</counter>
+                          <value>MISSEDCOUNT</value>
+                          <maximum>0</maximum>
                         </limit>
                         <limit>
-                          <counter>BRANCH</counter>
-                          <value>COVEREDRATIO</value>
-                          <minimum>1.00</minimum>
+                          <counter>LINE</counter>
+                          <value>MISSEDCOUNT</value>
+                          <maximum>0</maximum>
                         </limit>
                       </limits>
                     </rule>

diff --git a/.../java/tech/jhipster/lite/generator/server/javatool/jacoco/domain/JacocoModuleFactory.java b/.../java/tech/jhipster/lite/generator/server/javatool/jacoco/domain/JacocoModuleFactory.java
@@ -88,14 +88,14 @@ private static MavenPlugin mavenJacocoWithMinCoverageCheckPluginManagement() {
                   <element>CLASS</element>
                   <limits>
                     <limit>
-                      <counter>LINE</counter>
-                      <value>COVEREDRATIO</value>
-                      <minimum>1.00</minimum>
+                      <counter>BRANCH</counter>
+                      <value>MISSEDCOUNT</value>
+                      <maximum>0</maximum>
                     </limit>
                     <limit>
-                      <counter>BRANCH</counter>
-                      <value>COVEREDRATIO</value>
-                      <minimum>1.00</minimum>
+                      <counter>LINE</counter>
+                      <value>MISSEDCOUNT</value>
+                      <maximum>0</maximum>
                     </limit>
                   </limits>
                 </rule>
@@ -199,14 +199,14 @@ private static GradleMainBuildPlugin gradleJacocoWithMinCoverageCheckPlugin() {
 
                   limit {
                       counter = "LINE"
-                      value = "COVEREDRATIO"
-                      minimum = "1.00".toBigDecimal()
+                      value = "MISSEDCOUNT"
+                      maximum = "0.00".toBigDecimal()
                   }
 
                   limit {
                       counter = "BRANCH"
-                      value = "COVEREDRATIO"
-                      minimum = "1.00".toBigDecimal()
+                      value = "MISSEDCOUNT"
+                      maximum = "0.00".toBigDecimal()
                   }
               }
           }

diff --git a/src/test/features/server/javatool/jacoco.feature b/src/test/features/server/javatool/jacoco.feature
@@ -6,4 +6,4 @@ Feature: Jacoco module
 
   Scenario: Should apply jacoco with min coverage check module
     When I apply "jacoco-with-min-coverage-check" module to default project with maven file without parameters
-    Then I should have "<value>COVEREDRATIO</value>" in "pom.xml"
+    Then I should have "<value>MISSEDCOUNT</value>" in "pom.xml"
diff --git a/...a/tech/jhipster/lite/generator/server/javatool/jacoco/domain/JacocoModuleFactoryTest.java b/...a/tech/jhipster/lite/generator/server/javatool/jacoco/domain/JacocoModuleFactoryTest.java
@@ -124,14 +124,14 @@ void shouldBuildJacocoWithMinCoverageCheckModule() {
                               <element>CLASS</element>
                               <limits>
                                 <limit>
-                                  <counter>LINE</counter>
-                                  <value>COVEREDRATIO</value>
-                                  <minimum>1.00</minimum>
+                                  <counter>BRANCH</counter>
+                                  <value>MISSEDCOUNT</value>
+                                  <maximum>0</maximum>
                                 </limit>
                                 <limit>
-                                  <counter>BRANCH</counter>
-                                  <value>COVEREDRATIO</value>
-                                  <minimum>1.00</minimum>
+                                  <counter>LINE</counter>
+                                  <value>MISSEDCOUNT</value>
+                                  <maximum>0</maximum>
                                 </limit>
                               </limits>
                             </rule>
@@ -228,14 +228,14 @@ void shouldBuildJacocoWithMinCoverageCheckModule() {
 
                   limit {
                       counter = "LINE"
-                      value = "COVEREDRATIO"
-                      minimum = "1.00".toBigDecimal()
+                      value = "MISSEDCOUNT"
+                      maximum = "0.00".toBigDecimal()
                   }
 
                   limit {
                       counter = "BRANCH"
-                      value = "COVEREDRATIO"
-                      minimum = "1.00".toBigDecimal()
+                      value = "MISSEDCOUNT"
+                      maximum = "0.00".toBigDecimal()
                   }
               }
           }