Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CMB2 Conditionals on front-end. #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable CMB2 Conditionals on front-end. #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmb2-conditionals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ jQuery( document ).ready( function( $ ) {
function CMB2ConditionalsInit( changeContext, conditionContext ) {
var loopI, requiredElms, uniqueFormElms, formElms;

if ( 'undefined' === typeof changeContext ) {
if ( 'undefined' === typeof changeContext || $( changeContext ).length < 1 ) {
changeContext = 'body';
}
changeContext = $( changeContext );

if ( 'undefined' === typeof conditionContext ) {
if ( 'undefined' === typeof conditionContext || $( conditionContext ).length < 1 ) {
conditionContext = 'body';
}
conditionContext = $( conditionContext );
Expand Down
18 changes: 18 additions & 0 deletions cmb2-conditionals.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ public function __construct() {
add_action( 'admin_init', array( $this, 'admin_init' ), self::PRIORITY );
add_action( 'admin_footer', array( $this, 'admin_footer' ), self::PRIORITY );

// Enable conditionals on front-end if using recent version of CMB2.
add_action( 'cmb2_footer_enqueue', array( $this, 'cmb2_footer' ), self::PRIORITY );
Copy link
Contributor

@jtsternberg jtsternberg Mar 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used CMB2 Conditionals, and I'm not sure about the context of when this hook happens, but I would make sure (maybe within the cmb2_footer callback) that you only enqueue the script if it is known for sure that is needed. You don't want to needlessly enqueue a script and slow down every page on the site if it is not needed.


foreach ( $this->maybe_required_form_elms as $element ) {
add_filter( "cmb2_{$element}_attributes", array( $this, 'maybe_set_required_attribute' ), self::PRIORITY );
}
Expand All @@ -113,6 +116,21 @@ public function admin_footer() {
);
}

/**
* Ensure the cmb2-conditionals js-script is loaded everytime the CMB2 scripts are loaded. This does
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Ensure the cmb2-conditionals js-script is loaded everytime the CMB2 scripts are loaded. This does
* Ensure the cmb2-conditionals js is loaded every time the CMB2 scripts are loaded. This does

* not colide with "admin_footer()" or previeous way of script enqueueing, so back compatibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* not colide with "admin_footer()" or previeous way of script enqueueing, so back compatibility
* not collide with "admin_footer()" or previous way of script enqueueing, so back compatibility

* is maintained as well.
*/
public function cmb2_footer() {
wp_enqueue_script(
'cmb2-conditionals',
plugins_url( '/cmb2-conditionals.js', __FILE__ ),
array( 'jquery', 'cmb2-scripts' ),
self::VERSION,
true
);
}


/**
* Ensure valid html for the required attribute.
Expand Down