Enable CMB2 Conditionals on front-end. #72
Conversation
…version. No change for older versions.
|
Ping @jtsternberg |
|
Maybe we need to remove support for PHP 5.2 and 5.3. What about removing them from travis? |
There was a problem hiding this comment.
As I mentioned in one of the comments, I'm ashamed to say I've never used this library, but I did leave some comments/suggestions. @jcchavezs let me know if you had something else in mind for me.
| @@ -113,6 +116,21 @@ public function admin_footer() { | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Ensure the cmb2-conditionals js-script is loaded everytime the CMB2 scripts are loaded. This does | |||
| * not colide with "admin_footer()" or previeous way of script enqueueing, so back compatibility | |||
There was a problem hiding this comment.
| * not colide with "admin_footer()" or previeous way of script enqueueing, so back compatibility | |
| * not collide with "admin_footer()" or previous way of script enqueueing, so back compatibility |
| @@ -113,6 +116,21 @@ public function admin_footer() { | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Ensure the cmb2-conditionals js-script is loaded everytime the CMB2 scripts are loaded. This does | |||
There was a problem hiding this comment.
| * Ensure the cmb2-conditionals js-script is loaded everytime the CMB2 scripts are loaded. This does | |
| * Ensure the cmb2-conditionals js is loaded every time the CMB2 scripts are loaded. This does |
| @@ -91,6 +91,9 @@ public function __construct() { | |||
| add_action( 'admin_init', array( $this, 'admin_init' ), self::PRIORITY ); | |||
| add_action( 'admin_footer', array( $this, 'admin_footer' ), self::PRIORITY ); | |||
|
|
|||
| // Enable conditionals on front-end if using recent version of CMB2. | |||
| add_action( 'cmb2_footer_enqueue', array( $this, 'cmb2_footer' ), self::PRIORITY ); | |||
There was a problem hiding this comment.
I've never used CMB2 Conditionals, and I'm not sure about the context of when this hook happens, but I would make sure (maybe within the cmb2_footer callback) that you only enqueue the script if it is known for sure that is needed. You don't want to needlessly enqueue a script and slow down every page on the site if it is not needed.
Enable CMB2 Conditionals on front-end when using latest CMB2 version. No change for older versions.
The use of "cmb2_footer_enqueue" is applied only when it is available. Meaning if user has CMB2 without this hook - nothing changes.
In the JS we actually check if the "changeContext" and "conditionContext" elements exist. If not, we use the "body" selector. Again everything works as before only if the script is loaded on front-end, there is no "#post" therefore we need to use "body" instead.