Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible to embed into theme #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make compatible to embed into theme #7

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4441ce6
Use wp_enqueue_scripts hook instead of admin_footer to enqueue script
theKhorshed Dec 9, 2015
709be64
Make the JS enqueue url compatible with both theme and plugin
theKhorshed Dec 9, 2015
2550f04
fix js enqueue problem
theKhorshed Dec 9, 2015
fd86fbc
Use CMB2 Utility function
theKhorshed Feb 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions cmb2-conditionals.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,20 @@ function cmb2_conditionals_load_actions()
define('CMB2_CONDITIONALS_PRIORITY', 99999);

add_action('admin_init', 'cmb2_conditionals_hook_data_to_save_filtering', CMB2_CONDITIONALS_PRIORITY);
add_action('admin_footer', 'cmb2_conditionals_footer', CMB2_CONDITIONALS_PRIORITY);
}

add_action('admin_enqueue_scripts', 'cmb2_conditionals_footer', CMB2_CONDITIONALS_PRIORITY);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the hook change but I do not understand why to move this out of the function. Can you @theKhorshed please explain it to me?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, It was actually not working inside the function. Probably because the function is called by the 'plugins_loaded' hook.

/**
* Decides whether include the scripts or not.
*/
function cmb2_conditionals_footer()
function cmb2_conditionals_footer($hook)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. I was not aware of this.

{
global $pagenow;
if( $hook != 'post.php' && $hook != 'post-new.php' ){
return;
}

if(!in_array($pagenow, array('post-new.php', 'post.php'))) {
return;
}

wp_enqueue_script('cmb2-conditionals', plugins_url('/cmb2-conditionals.js', __FILE__ ), array('jquery'), '1.0.2', true);
$url = CMB2_Utils::get_url_from_dir( trailingslashit( dirname( __FILE__ ) ) )
wp_enqueue_script('cmb2-conditionals', $url . 'cmb2-conditionals.js', array('jquery'), '1.0.2', true);
}

/**
Expand Down Expand Up @@ -86,4 +85,4 @@ function cmb2_conditional_filter_data_to_save(CMB2 $cmb2, $object_id)
continue;
}
}
}
}