Make compatible to embed into theme #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| add_action('admin_enqueue_scripts', 'cmb2_conditionals_footer', CMB2_CONDITIONALS_PRIORITY); |
There was a problem hiding this comment.
I like the hook change but I do not understand why to move this out of the function. Can you @theKhorshed please explain it to me?
There was a problem hiding this comment.
Hi, It was actually not working inside the function. Probably because the function is called by the 'plugins_loaded' hook.
|
Hi @theKhorshed - first of all, thanks a lot for contributing, I really like the fact that people try to add improvements proactively. Awesome! |
| /** | ||
| * Decides whether include the scripts or not. | ||
| */ | ||
| function cmb2_conditionals_footer() | ||
| function cmb2_conditionals_footer($hook) |
There was a problem hiding this comment.
Nice improvement. I was not aware of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to embed the plugin inside my theme but got issue with enqueueing the JS. I have tried to make the enqueue url compatible with both theme and plugin.
Thanks for the great work.