Fixed issue with PretokenizeRunner with streaming=True #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug with PretokenizerRunner when
streaming=True
due to differences in interface withDataset
andIterableDataset
. Specifically,num_proc
is an argument to themap
method for the former but not the latter. Similarly,Dataset
usesset_format
andIterableDataset
useswith_format
. Added test.Also replaced a usage of deprecated
pretokenize_runner
withPretokenizeRunner
in a separate test.Fixes #441
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and tests
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)