Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: containerized apps #1366

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

dopry
Copy link
Contributor

@dopry dopry commented Nov 11, 2023

Description of the Change

  • add Dockerfile to build the tests/app/idp
  • add Dockerfile to build the tests/app/rp
  • add a docker compose file to build and start instances of the idp and rp

You can test this setup with
docker-compose up

This could be nice for testing new branches with the following

docker-compose down -v # remove existing env
docker-compose build      # rebuild the images
docker-compose up          # spin up the docker  compose environment

You should be able to goto http://localhost:5173 and http://localhost:8000 to access the compose instances.

This is a precursor to publishing the test IDP as a container via docker hub. I hope making a Django based IDP more accessible will help grow our contributor and user community.

Checklist

  • PR only contains one change (considered splitting up PR)

  • [N/A ] unit-test added

  • documentation updated

    I wasn't quite sure where or how to document this at this juncture. I'm open to ideas.

  • [N/A] CHANGELOG.md updated (only for user relevant changes)

  • author name in AUTHORS

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (560f84d) to head (04e9fa2).
Report is 18 commits behind head on master.

Current head 04e9fa2 differs from pull request most recent head 5624cb0

Please upload reports for the commit 5624cb0 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   97.56%   97.54%   -0.02%     
==========================================
  Files          32       32              
  Lines        2132     2120      -12     
==========================================
- Hits         2080     2068      -12     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dopry dopry force-pushed the feat/idp-settings-django-environ branch 2 times, most recently from 9e98388 to e952ca3 Compare November 13, 2023 15:50
@dopry dopry force-pushed the feat/idp-settings-django-environ branch from e952ca3 to 04e9fa2 Compare November 21, 2023 21:43
@n2ygk
Copy link
Member

n2ygk commented May 7, 2024

@dopry this looks like a cool idea. Sorry for the delay in looking. Documentation could be short and simple -- "use docker-compose up to start up an OAuth server".

I had started doing something similar here https://github.com/n2ygk/dot-tutorial using Heroku and an attempt to try out some OIDC certification testing. See the notes

There's a bunch of conflicts now -- maybe I merged something prematurely?

@n2ygk n2ygk added this to the 2.5.0 milestone May 20, 2024
@dopry
Copy link
Contributor Author

dopry commented Jun 10, 2024

No worries. I'll update it when I get a chance.

@dopry dopry force-pushed the feat/idp-settings-django-environ branch from 04e9fa2 to 4b33767 Compare June 12, 2024 12:54
@n2ygk n2ygk force-pushed the feat/idp-settings-django-environ branch from 4b33767 to 2a1f1d8 Compare June 12, 2024 13:47
@dopry dopry force-pushed the feat/idp-settings-django-environ branch from 35136e1 to 2a1f1d8 Compare June 12, 2024 14:00
@dopry dopry force-pushed the feat/idp-settings-django-environ branch from 2a1f1d8 to 5f9e088 Compare June 13, 2024 13:33
@dopry
Copy link
Contributor Author

dopry commented Jun 13, 2024

@n2ygk This should be rebased and ready for a cursory review.

@n2ygk n2ygk force-pushed the feat/idp-settings-django-environ branch from 5f9e088 to 5624cb0 Compare June 17, 2024 13:19
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was able to fire up the docker container and did some minor testing (just a GET http://localhost:8000/o/.well-known/openid-configuration and a few of the links there)

Regarding future documentation, perhaps update https://django-oauth-toolkit.readthedocs.io/en/latest/tutorial/tutorial_01.html or add a new chapter to the tutorial?

@n2ygk n2ygk merged commit 133ba85 into jazzband:master Jun 17, 2024
27 checks passed
@dopry dopry deleted the feat/idp-settings-django-environ branch July 10, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants