-
-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: containerized apps #1366
feat: containerized apps #1366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1366 +/- ##
==========================================
- Coverage 97.56% 97.54% -0.02%
==========================================
Files 32 32
Lines 2132 2120 -12
==========================================
- Hits 2080 2068 -12
Misses 52 52 ☔ View full report in Codecov by Sentry. |
9e98388
to
e952ca3
Compare
e952ca3
to
04e9fa2
Compare
@dopry this looks like a cool idea. Sorry for the delay in looking. Documentation could be short and simple -- "use docker-compose up to start up an OAuth server". I had started doing something similar here https://github.com/n2ygk/dot-tutorial using Heroku and an attempt to try out some OIDC certification testing. See the notes There's a bunch of conflicts now -- maybe I merged something prematurely? |
No worries. I'll update it when I get a chance. |
04e9fa2
to
4b33767
Compare
4b33767
to
2a1f1d8
Compare
35136e1
to
2a1f1d8
Compare
2a1f1d8
to
5f9e088
Compare
@n2ygk This should be rebased and ready for a cursory review. |
5f9e088
to
5624cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I was able to fire up the docker container and did some minor testing (just a GET http://localhost:8000/o/.well-known/openid-configuration and a few of the links there)
Regarding future documentation, perhaps update https://django-oauth-toolkit.readthedocs.io/en/latest/tutorial/tutorial_01.html or add a new chapter to the tutorial?
Description of the Change
You can test this setup with
docker-compose up
This could be nice for testing new branches with the following
You should be able to goto http://localhost:5173 and http://localhost:8000 to access the compose instances.
This is a precursor to publishing the test IDP as a container via docker hub. I hope making a Django based IDP more accessible will help grow our contributor and user community.
Checklist
PR only contains one change (considered splitting up PR)
[N/A ] unit-test added
documentation updated
I wasn't quite sure where or how to document this at this juncture. I'm open to ideas.
[N/A]
CHANGELOG.md
updated (only for user relevant changes)author name in
AUTHORS