fix: test/app/rp npm install failing #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopry
changed the title
dopry
force-pushed
the
fix/broken-test-app-rp
branch
4 times, most recently
from
328c2de to
810625b
Compare
dopry
force-pushed
the
fix/broken-test-app-rp
branch
2 times, most recently
from
400bba4 to
0fe1b7f
Compare
it seems we merged a major update from dependabot to some of the RP dependencies that were incompatible with some of the other package versions. This resolves that and updates the RP to Svelte4/SvelteKit 2. Test by following the instructions in /test/app/README.md to launch the local environment.
dopry
force-pushed
the
fix/broken-test-app-rp
branch
from
0fe1b7f to
b6d770f
Compare
|
@dopry looks like this workflow failed: Invalid workflow file: .github/workflows/test.yml#L120 |
n2ygk
requested changes
Jun 12, 2024
Co-authored-by: Alan Crosswell <[email protected]>
|
That's what I get for doing last minute rename changes |
n2ygk
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems we merged a major update from dependabot to some of the RP dependencies that were incompatible with some of the other package versions. This resolves that and updates the RP to Svelte4/SvelteKit 2.
Test by following the instructions in /test/app/README.md to launch the local environment.