Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operators #147

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Operators #147

wants to merge 13 commits into from

Conversation

Gabitzzz
Copy link
Contributor

No description provided.

bogdanbacosca
bogdanbacosca requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mai avem câteva completări de făcut înainte să lipim acest PR cu main branch.
În cea mai mare parte trebuiesc adăugate diacritice la toate mențiunile (în alte părți dacă este necesar) și rescrise cuvintele greșite.
Foarte important Trebuiesc verificate liniile să se potrivească 1 la 1 cu originalul, să nu fie linii șterse sau adăugate în plus.

Almost there.

1-js/02-first-steps/08-operators/4-fix-prompt/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
@@ -1,32 +1,31 @@
The reason is that prompt returns user input as a string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

După instrucțiuni, trebuie să păstrăm liniile "așa cum sunt". Acest lucru reduce conflictele de merge.
Sugestie: adaugă o linie goală între linia 1 și 2.

1-js/02-first-steps/08-operators/4-fix-prompt/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/4-fix-prompt/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/4-fix-prompt/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Gabitzzz and others added 8 commits November 28, 2022 13:05
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
7fcf68d 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
3187282 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/4-fix-prompt/task.md
ded9060 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/article.md
2720578 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/article.md
4ff45cc 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/article.md
41866b9 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/4-fix-prompt/task.md
bc536b9 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/article.md
2d28aa6 
Co-authored-by: Bogdan Bacosca <[email protected]>
bogdanbacosca
bogdanbacosca requested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversațiile trebuie adresate.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gabitzzz @javascript-translate-bot @bogdanbacosca