-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload data #5667
Preload data #5667
Conversation
JAGS en SEM are not supported properly |
Specifically, no support for:
|
Im currently finishing support for changing type with dropdown in filterconstructor. Then I need to add a property to modules and analyses that states "I can handle datasets being passed as an argument" aka "preloadData" or something. And further I want to remove the "keeping types" and "converting types" cause it really isnt necessary anymore. |
235ad8f
to
1466cf6
Compare
All the changes have been made, Ill update the PR description to reflect the changes. |
1466cf6
to
2c5b261
Compare
It works nearly perfect. But now if I close the Variable Window, it says nearly always "Would you like to save your changes to the Computed Column": The computed column help should be updated. |
…r each analysis Implements jasp-stats/INTERNAL-jasp#2583 Has corresponding changes in jaspBase, jaspModuleEncoder and jaspDescriptives fix some merge errors and bugs add syntaxhighlighting to computecolumn R display move focus to button on apply filter so text-entry is editFinished columntype in filterconstructor now follows dataset changes filterconstructor now has changeable columntypes! force active focus on apply button in filter and comp col to focus out of constructor and trigger proper checks remove last remnants of "keeping/converting columntypes" started work on preloading data config in Description.qml Add preloadData argument to analysisrunflow and decode to type
2c5b261
to
3c8b4c2
Compare
The help is updated and the apply thing should now only bother you when you made changes ;) |
@vandenman Do you have time to review this PR today? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not looked at the code in depth, but I did try this out and it build and worked fine.
* Encode types of variables into their encoded names to preload data for each analysis Implements jasp-stats/INTERNAL-jasp#2583 Has corresponding changes in jaspBase, jaspModuleEncoder and jaspDescriptives fix some merge errors and bugs add syntaxhighlighting to computecolumn R display move focus to button on apply filter so text-entry is editFinished columntype in filterconstructor now follows dataset changes filterconstructor now has changeable columntypes! force active focus on apply button in filter and comp col to focus out of constructor and trigger proper checks remove last remnants of "keeping/converting columntypes" started work on preloading data config in Description.qml Add preloadData argument to analysisrunflow and decode to type * set default off for preloadData * fix annoying "computed column changed wanna save" popping up too much * add some info on type changing in computed column help * add some info on changing types to filter help
Also merge: jasp-stats/jaspColumnEncoder#9 and jasp-stats/jaspBase#152
Ive also made some small changes to jaspDescriptives: jasp-stats/jaspDescriptives#314
for jasp-stats/INTERNAL-jasp#2583
Don't forget
git submodule update
;)This adds support for automatic preloading of data for analyses. By default Ive turned it off to ease the transition but ideally that would be on. This is done through the
preloadData
property onDescription
andAnalysis
in Description.qml.If disabled it will act like 0.19(.1). Basically adding an "optionname.types" and flattening "optionname" option into just the names.
It encodes all the columnname-options to their columnname+requested type if they have one. (Which is the case for the variableslists etc). And then gives the analysis a flat list of encoded columnnames that will refer to the column in the dataset with the specific version of the data requested.
There is now also jaspRcpp support for the columnencoder where it can give the type back. This has not been implemented all the way to R though.
The confusing "Keeping types" and "Converting types" button in computed column window has now been removed.
This because the columns in filterconstructor and computed columnconstructor now have support for transforming their datatype locally (including showing the preview a la variables list).
This is also available in R-code as "V1.ordinal" etc.
The syntaxhighlighting will also help indicate this.