Computed column fixes #5676
Merged
Computed column fixes #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this by including the R-files with "friendly functions" from jaspBase into Engine and then passing that as an init-script to the engine. Fixes jasp-stats/INTERNAL-jasp#2653
|
This does not work for Ordinal or Nominal computed column: if you change the computed column to Ordinal or Nominal it still gives NA's. If you also make directly an ordinal computed column (with the + button in Analysis mode), it also gives NA's. |
|
Disable "Converting types", or in any case, make sure all the types make sense I will remove that functionality once #5667 gets merged |
boutinb
approved these changes
Sep 25, 2024
JorisGoosen
added a commit
that referenced
this pull request
Sep 30, 2024
* Handle TRUE/FALSE better in compute columns Fixes jasp-stats/jasp-issues#2927 * dont require jaspBase for computed columns etc Do this by including the R-files with "friendly functions" from jaspBase into Engine and then passing that as an init-script to the engine. Fixes jasp-stats/INTERNAL-jasp#2653 * actually fix the problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jasp-stats/jasp-issues#2927 (getting TRUE/FALSE instead of 1/0) and https://github.com/jasp-stats/INTERNAL-jasp/issues/2653 (computed columns dont work in development...)