Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue ellipsis text on model selector and model start loader #3802

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Oct 15, 2024

Describe Your Changes

File: web/containers/Loader/ModelStart.tsx

  • Styling: These changes enhance the visual presentation by ensuring that the loader and state text do not overflow beyond 300 pixels in width. Truncation with an ellipsis prevents content from stretching unnecessarily.
  • Readability: The removal of line-clamp means the full text is now visible if it fits within the container, which might improve readability for longer model IDs.

File: web/containers/ModelDropdown/index.tsx

  • Styling: These changes enhance the visual presentation by ensuring that the model name does not overflow beyond 200 pixels in width. Truncation with an ellipsis prevents content from stretching unnecessarily.
  • Readability: The removal of line-clamp means the full text is now visible if it fits within the container, which might improve readability for longer model names.

Summary:

The changes made to both files aim to improve the visual presentation by controlling the width of elements that could potentially grow large, ensuring they do not overflow their containers. This helps in maintaining a cleaner and more consistent layout across different screen sizes and content lengths.

Fixes Issues

Screenshot 2024-10-15 at 11 24 43

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added type: bug Something isn't working category: threads & chat Threads & chat UI UX issues labels Oct 15, 2024
@urmauur urmauur added this to the v0.5.7 milestone Oct 15, 2024
@urmauur urmauur self-assigned this Oct 15, 2024
@urmauur urmauur changed the title fix: issue ellipsis text on model selector and loader model start fix: issue ellipsis text on model selector and model start loader Oct 15, 2024
Copy link
Contributor

Barecheck - Code coverage report

Total: 68.95%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/containers/Loader/ModelStart.tsx12-14, 16-18, 20-22, 24-25, 27
web/containers/ModelDropdown/index.tsx102, 118-119, 122, 124-125, 127-128, 130-133, 135, 143, 160-162, 164, 166, 186, 190, 197, 200-201, 237-239, 243, 265-266, 270, 273-278, 285-286, 297, 301, 319, 335, 356, 365, 371, 379-380, 383-388, 391, 394, 446-447, 449, 474, 478, 480, 503, 505-506, 508, 512-514, 516-517, 519, 529-532, 559, 563, 565

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 5e8a27b into dev Oct 15, 2024
11 checks passed
@urmauur urmauur deleted the fix/misc-chat-issue branch October 15, 2024 05:57
@imtuyethan imtuyethan mentioned this pull request Oct 15, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: threads & chat Threads & chat UI UX issues type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Misc chat UI issues
2 participants