Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Misc chat UI issues #3759

Closed
3 tasks done
imtuyethan opened this issue Oct 2, 2024 · 3 comments · Fixed by #3802
Closed
3 tasks done

bug: Misc chat UI issues #3759

imtuyethan opened this issue Oct 2, 2024 · 3 comments · Fixed by #3802
Assignees
@urmauur
Labels
category: threads & chat Threads & chat UI UX issues type: bug Something isn't working
Milestone
v0.5.7

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Oct 2, 2024 •
edited
Loading

Jan version

0.5.4-652

Describe the Bug

  1. The text should expand til it fills the field 100%
Screenshot_2024-10-02_at_3 55 15_PM
  1. Import modal still shows up after i click use model
    https://github.com/user-attachments/assets/e601bc78-1b59-48a7-9bfb-c5c13b50f18e

What is your OS?

  • MacOS
  • Windows
  • Linux
@imtuyethan imtuyethan added the type: bug Something isn't working label Oct 2, 2024
@imtuyethan imtuyethan added this to the v0.5.6 milestone Oct 2, 2024
@imtuyethan imtuyethan changed the title bug: Import modal still shows up after i click use model bug: Some UI issues Oct 2, 2024
@0xSage 0xSage assigned 0xSage and unassigned urmauur Oct 14, 2024
@0xSage
Copy link
Contributor

0xSage commented Oct 14, 2024 •
edited
Loading

Let's avoid assigning to eng until we've fully scoped out the issue.

  1. What is the expected? Maybe you can show a quick mock, I'm a bit confused
  2. I'm not sure the attached screen recording is related to the issue, can you elaborate?

Edit: nevermind, I see that @urmauur already started on this, so he must already have context. Pls ignore my comments above.

@0xSage 0xSage added the needs pm Feature request is not clear, needs product decisions label Oct 14, 2024
@0xSage 0xSage removed this from the v0.5.7 milestone Oct 14, 2024
@0xSage 0xSage added the category: threads & chat Threads & chat UI UX issues label Oct 14, 2024
@0xSage 0xSage changed the title bug: Some UI issues bug: Misc chat UI issues Oct 14, 2024
@0xSage 0xSage assigned urmauur and unassigned 0xSage Oct 14, 2024
@0xSage 0xSage removed the needs pm Feature request is not clear, needs product decisions label Oct 14, 2024
@urmauur urmauur mentioned this issue Oct 15, 2024
Merged
3 tasks
@0xSage 0xSage added this to the v0.5.7 milestone Oct 15, 2024
@imtuyethan
Copy link
Contributor Author

imtuyethan commented Oct 15, 2024 •
edited
Loading

Sorry @urmauur sorry to keep nitpicking on this, but I still find it a bit odd:

Screen.Recording.2024-10-15.at.11.24.10.PM.mov

Here’s how I think it could be improved:

  • The box should dynamically adjust to fit the content.
  • Set a maximum width for the box. Once the content exceeds the limit, it should be truncated with an ellipsis (“abc…”).

@imtuyethan imtuyethan reopened this Oct 15, 2024
@imtuyethan
Copy link
Contributor Author

This issue will be fixed here: #3802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urmauur urmauur

Labels
category: threads & chat Threads & chat UI UX issues type: bug Something isn't working
Projects
Jan & Cortex
Archived in project
Milestone
v0.5.7
Development

Successfully merging a pull request may close this issue.

fix: issue ellipsis text on model selector and model start loader janhq/jan
3 participants
@urmauur @0xSage @imtuyethan