-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feedback from shapetrees-js@2ef2476 #126
Open
ericprud
wants to merge
10
commits into
main
Choose a base branch
from
develop.ericP-toTypescript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 23, 2021
-
Eric Prud'hommeaux committed
Nov 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 26ab3f6 - Browse repository at this point
Copy the full SHA 26ab3f6View commit details
Commits on Nov 24, 2021
-
Eric Prud'hommeaux committed
Nov 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 281e3d6 - Browse repository at this point
Copy the full SHA 281e3d6View commit details -
~ fix off-by-one error in javatots
Eric Prud'hommeaux committedNov 24, 2021 Configuration menu - View commit details
-
Copy full SHA for b31aef9 - Browse repository at this point
Copy the full SHA b31aef9View commit details -
+ map java.util.Optional<X> to X | null
Eric Prud'hommeaux committedNov 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 519c0c6 - Browse repository at this point
Copy the full SHA 519c0c6View commit details -
Eric Prud'hommeaux committed
Nov 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 676aa55 - Browse repository at this point
Copy the full SHA 676aa55View commit details -
~ strip out lombok.extern.slf4j.Slf4j
Eric Prud'hommeaux committedNov 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 5752669 - Browse repository at this point
Copy the full SHA 5752669View commit details -
~ ArrayList -> Array, HashMap -> Map
Eric Prud'hommeaux committedNov 24, 2021 Configuration menu - View commit details
-
Copy full SHA for c2c035a - Browse repository at this point
Copy the full SHA c2c035aView commit details -
Eric Prud'hommeaux committed
Nov 24, 2021 Configuration menu - View commit details
-
Copy full SHA for de1cc05 - Browse repository at this point
Copy the full SHA de1cc05View commit details
Commits on Dec 7, 2021
-
Eric Prud'hommeaux committed
Dec 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 58ab9c5 - Browse repository at this point
Copy the full SHA 58ab9c5View commit details
Commits on Dec 24, 2021
-
~ feedback from shapetrees-js@2ef2476
Eric Prud'hommeaux committedDec 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 408f77d - Browse repository at this point
Copy the full SHA 408f77dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.