Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback from shapetrees-js@2ef2476 #126

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feedback from shapetrees-js@2ef2476 #126

wants to merge 10 commits into from

Conversation

ericprud
Copy link
Collaborator

some TODOs and minor tweeks from first pass through ts-ifying

@ericprud ericprud force-pushed the develop.ericP-toTypescript branch 3 times, most recently from f27fb53 to 4a9fecb Compare December 24, 2021 10:20
@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

84.5% 84.5% Coverage
0.0% 0.0% Duplication

justinwb
justinwb requested changes Dec 26, 2021
View reviewed changes
Copy link
Member

@justinwb justinwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericprud seems a bunch of the typescript library code was mistakenly included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwb justinwb justinwb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericprud @justinwb