Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dynamic changes to shelljs to resolve the problem with file extensions at runtime #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement dynamic changes to shelljs to resolve the problem with file extensions at runtime #1

wants to merge 1 commit into from

Conversation

ivanduplenskikh
Copy link
Owner

Description

Motivation

Related Issue(s), If Filed

Testing

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the changelog using the script npm run newChange

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi
feat(node): support node 20 in tasks
634462a 
Requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <ivanduplenskikh>
@hayemaxi hayemaxi mentioned this pull request Nov 25, 2024
Merged
5 tasks
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi
feat(node): support node 20 in tasks
a7fc4af 
Requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <ivanduplenskikh>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi
feat(node): support node 20 in tasks
72c1ba5 
Requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <ivanduplenskikh>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi
feat(node): support node 20 in tasks
37ca2a3 
Requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <ivanduplenskikh>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi
feat(node): support node 20 in tasks
740cb25 
Requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <ivanduplenskikh>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
416cb88 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
415329e 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
18bee1b 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
7fb231a 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
f5073d0 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
9856282 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
b699175 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
f05199a 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
345c5ff 
Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Addresses aws#566

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Nov 25, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
6229150 
Addresses aws#566. Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback. However, we are still building the node10 with esbuild to ensure backwards compatibility. In the future, we can consider building for a higher node version only.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to hayemaxi/aws-toolkit-azure-devops that referenced this pull request Dec 2, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks
6b999e6 
Addresses aws#566. Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback. However, we are still building the node10 with esbuild to ensure backwards compatibility. In the future, we can consider building for a higher node version only.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
hayemaxi added a commit to aws/aws-toolkit-azure-devops that referenced this pull request Dec 3, 2024
@hayemaxi @ivanduplenskikh
feat(node): support node 20 in tasks (#581)
d6157e0 
Addresses #566. Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback. However, we are still building the node10 with esbuild to ensure backwards compatibility. In the future, we can consider building for a higher node version only.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in #539

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivanduplenskikh