feat(node): support node 20 in tasks

Requires a hacky patch to fix shell.js, which doesn't support bundlers.
Mitigates the issue described in aws#539

Credit to ivanduplenskikh:  ivanduplenskikh#1

Co-authored-by: Ivan Duplenskikh <ivanduplenskikh>

.changes/next-release/Feature-cb2222ff-2158-4c85-ab41-b109d7f42092.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "Tasks now support Node 20"
+}

.vscode/settings.json

@@ -1,14 +1,7 @@
 {
-    "files.exclude": {
-        "build": true,
-        "package": true,
-        "package-lock.json": true,
-        ".vscode": true
-    },
+    "files.exclude": {},
     "search.exclude": {
-        "build": true,
-        "package": true,
-        ".vscode": true
+        "package": true
     },
     "json.schemas": [
         {

build-scripts/packageExtension.ts

@@ -69,6 +69,24 @@ function packagePlugin(options: CommandLineOptions) {
     // get required npm packages that will be copied
     installNodePackages(npmFolder)
 
+    /**
+     * Patch shelljs, because it is not compatible with esbuild
+     * More info: https://github.com/aws/aws-toolkit-azure-devops/pull/539
+     */
+    const shelljsRootPath = path.resolve(process.cwd(), './node_modules/shelljs/')
+    const shelljsEntryPath = path.join(shelljsRootPath, 'shell.js')
+    const sourceRequireString =
+        "require('./commands').forEach(function (command) {\n  require('./src/' + command);\n});"
+    const originContent = fs.readFileSync(shelljsEntryPath, 'utf-8')
+
+    // eslint-disable-next-line @typescript-eslint/no-var-requires
+    const fixedRequireString = require(path.join(shelljsRootPath, 'commands.js'))
+        .map((command: string) => `require('./src/${command}.js');`)
+        .join('\n')
+
+    fs.writeFileSync(shelljsEntryPath, originContent.replace(sourceRequireString, fixedRequireString))
+    /** *************************************************************** */
+
     // clean, dedupe and pack each task as needed
     findMatchingFiles(folders.sourceTasks).forEach(function(taskName) {
         console.log('Processing task ' + taskName)
@@ -116,7 +134,7 @@ function packagePlugin(options: CommandLineOptions) {
                 entryPoints: [inputFilename],
                 bundle: true,
                 platform: 'node',
-                target: ['node10'],
+                target: ['node10', 'node20'],
                 minify: true,
                 outfile: `${taskPackageFolder}/${taskName}.js`
             })
@@ -127,6 +145,9 @@ function packagePlugin(options: CommandLineOptions) {
         }
     })
 
+    // undo shelljs patch
+    fs.writeFileSync(shelljsFilePath, originContent.replace(fixedRequireString, sourceRequireString))
+
     console.log('Creating deployment vsix')
 
     const binName = os.platform() === 'win32' ? `tfx.cmd` : 'tfx'