Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite streams logic #3620

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SamantazFox
Copy link
Member

@SamantazFox SamantazFox requested a review from a team as a code owner February 5, 2023 20:24
@SamantazFox SamantazFox requested review from unixfox and removed request for a team February 5, 2023 20:24
@SamantazFox SamantazFox marked this pull request as draft February 5, 2023 20:25
@ChunkyProgrammer
Copy link
Contributor

ChunkyProgrammer commented Mar 22, 2023

Here are some useful test videos for multi-audio tracks:

@PikachuEXE
Copy link

Also here is a video with missing attributes on some formats (AV1): https://youtu.be/8IFwpI7OT6I
From FreeTubeApp/FreeTube#3382

@Zero3K

This comment was marked as resolved.

@unixfox

This comment was marked as resolved.

@Zero3K

This comment was marked as resolved.

@unixfox

This comment was marked as resolved.

Copy link
Contributor

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked anything else as this still seems to be work in progress, but I just thought I would mention that as I saw it while flying over the code.

src/invidious/jsonify/api_v1/video_json.cr Outdated Show resolved Hide resolved
@absidue
Copy link
Contributor

absidue commented Nov 24, 2023

Could you please include the bitrate for the formatStreams in the API, I know it's not used by Invidious, but it's returned by YouTube and I would like to display it in FreeTube's debug/stats overlay.

src_url += "&local=true" if params.local

bitrate = fmt["bitrate"]
mimetype = HTML.escape(fmt["mimeType"].as_s)
bitrate = fmt.bitrate // 1000
Copy link

@hikkamorii hikkamorii Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is an improvement, it's still ambiguous whether AAC or Opus is used. Also, the "k" will be appended later, and it will not be inline with how it works when selecting audio quality for video. (feel free to ask me for patch that will add codec for the selection)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants