-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite streams logic #3620
base: master
Are you sure you want to change the base?
Rewrite streams logic #3620
Conversation
888a548
to
1adb035
Compare
Here are some useful test videos for multi-audio tracks:
|
Also here is a video with missing attributes on some formats (AV1): https://youtu.be/8IFwpI7OT6I |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1adb035
to
ee8e65e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked anything else as this still seems to be work in progress, but I just thought I would mention that as I saw it while flying over the code.
ee8e65e
to
a60a78b
Compare
Could you please include the bitrate for the formatStreams in the API, I know it's not used by Invidious, but it's returned by YouTube and I would like to display it in FreeTube's debug/stats overlay. |
src_url += "&local=true" if params.local | ||
|
||
bitrate = fmt["bitrate"] | ||
mimetype = HTML.escape(fmt["mimeType"].as_s) | ||
bitrate = fmt.bitrate // 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is an improvement, it's still ambiguous whether AAC or Opus is used. Also, the "k" will be appended later, and it will not be inline with how it works when selecting audio quality for video. (feel free to ask me for patch that will add codec for the selection)
e0962b9
to
877ad2f
Compare
877ad2f
to
606591a
Compare
606591a
to
a85f579
Compare
WIP
This PR is meant to overhaul how the streams' data (
formats
/adaptativeFormats
) is parsed.Objectives: